[GitHub] thrift pull request #1128: THRIFT-3873: fix compiler warnings on windows wit...

[Jens-G <gi...@git.apache.org>]

Github user Jens-G commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1128#discussion_r94489293
  
    --- Diff: compiler/cpp/src/thrift/generate/t_erl_generator.cc ---
    @@ -984,10 +988,13 @@ void t_erl_generator::export_types_string(string name, int num) {
     }
     
     void t_erl_generator::export_function(t_function* tfunction, string prefix) {
    -
    +  t_struct::members_type::size_type num = tfunction->get_arglist()->get_members().size();
    +  if (num > std::numeric_limits<int>().max()) {
    --- End diff --
    
    I'm getting a warning at ` if (num > std::numeric_limits<int>().max()) { ` in this file and also in the erlang generator (2 occurences):
    
    `C4018: ">": Conflict between "signed" and "unsigned"`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---