[GitHub] asdf2014 commented on issue #5978: Extend various test timeouts.

[GitBox <gi...@apache.org>]

asdf2014 commented on issue #5978: Extend various test timeouts.
URL: https://github.com/apache/incubator-druid/pull/5978#issuecomment-414039382
 
 
   Hi, @gianm . Maybe put a timeout `Rule` in the head of test class, such as `@Rule public Timeout globalTimeout = Timeout.seconds(60)`, which will be better than placing the `@Test(timeout = 60_000L)` annotation in each method. Also, if we need increase the timeout value for some special test cases, we can add `@Test(timeout = 70_000L)` to them, because the `Test` annotation has a higher priority than the `Rule` instance. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org