[GitHub] [iceberg] gaborkaszab commented on a diff in pull request #5159: Drop table's root folder if the table owns it

[GitBox <gi...@apache.org>]

gaborkaszab commented on code in PR #5159:
URL: https://github.com/apache/iceberg/pull/5159#discussion_r953684886


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -177,20 +179,17 @@ public boolean dropTable(TableIdentifier identifier, boolean purge) {
     }
 
     try {
-      clients.run(
-          client -> {
-            client.dropTable(
-                database,
-                identifier.name(),
-                false /* do not delete data */,
-                false /* throw NoSuchObjectException if the table doesn't exist */);
-            return null;
-          });
-
+      clients.run(client -> {
+        client.dropTable(database, identifier.name(),
+            false /* do not delete data */,
+            false /* throw NoSuchObjectException if the table doesn't exist */);
+        return null;
+      });

Review Comment:
   Thanks @wypoon for your comment!
   Yes, I meanwhile I also learnt that this PR was a bit naive and it involves a much higher level topic about Catalogs being responsible to guarantee that dropping table location is safe.
   I think I'll close this PR, then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org