You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/23 02:18:06 UTC
[GitHub] [orc] dongjoon-hyun opened a new pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
dongjoon-hyun opened a new pull request #632:
URL: https://github.com/apache/orc/pull/632
### What changes were proposed in this pull request?
This PR aims to replace `mvn` with `mvnw` in `java.CMakeLists.txt`.
### Why are the changes needed?
Some old OSes like CentOS7 may have the old Maven installation. Maven Wrapper will prevent build and test failures.
### How was this patch tested?
Pass the CIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-765836399
cc @omalley and @pgaref
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-766414584
> cc @omalley and @pgaref
Late +1 on this -- thanks @dongjoon-hyun ! Tested the local Centos7 docker build as well and is fine :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-766419681
Hi, I made a PR, #633 . Could you review it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-766420211
Thank you, @pgaref and @williamhyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #632:
URL: https://github.com/apache/orc/pull/632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun merged pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #632:
URL: https://github.com/apache/orc/pull/632
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-766419681
Hi, I made a PR, #633 . Could you review it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-766414584
> cc @omalley and @pgaref
Late +1 on this -- thanks @dongjoon-hyun ! Tested the local Centos7 docker build as well and is fine :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #632: ORC-739: Use Maven Wrapper in java/CMakeLists.txt
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #632:
URL: https://github.com/apache/orc/pull/632#issuecomment-766420211
Thank you, @pgaref and @williamhyun !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org