You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/05/12 10:08:24 UTC

[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #2584: Test TypeConverters #2537

JiriOndrusek opened a new pull request #2584:
URL: https://github.com/apache/camel-quarkus/pull/2584


   fixes https://github.com/apache/camel-quarkus/issues/2537
   
   Covers https://github.com/apache/camel-quarkus/issues/2570 with tests.
   
   <!-- Uncomment and fill this section if your PR is not trivial
   [ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
   [ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
   [ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
   [ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
   [ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
   [ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #2584: Test TypeConverters #2537

Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #2584:
URL: https://github.com/apache/camel-quarkus/pull/2584#issuecomment-840425840


   @ppalaga Changes discussed in chat are done:
   
   - Converter tests are located in separated test file with its own resource.
   - Signatures of helper methods are changed to be easily readable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on pull request #2584: Test TypeConverters #2537

Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2584:
URL: https://github.com/apache/camel-quarkus/pull/2584#issuecomment-840397683


   The code per se looks good. As discussed, in the chat, could you please move the converter tests and JAX-RS endpoints to separate classes so that we keep an overviewable code structure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga merged pull request #2584: Test TypeConverters #2537

Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2584:
URL: https://github.com/apache/camel-quarkus/pull/2584


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org