[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #6651: Minor: add test cases for coercion bitwise shifts

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #6651:
URL: https://github.com/apache/arrow-datafusion/pull/6651#discussion_r1226893518


##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1696,6 +1696,18 @@ mod tests {
             DataType::UInt64,
             vec![11u64, 6u64, 7u64],
         );
+        test_coercion!(
+            UInt16Array,
+            DataType::UInt16,
+            vec![3u16, 2u16, 3u16],
+            UInt64Array,
+            DataType::UInt64,
+            vec![10u64, 6u64, 5u64],
+            Operator::BitwiseOr,
+            UInt64Array,
+            DataType::UInt64,
+            vec![11u64, 6u64, 7u64],
+        );

Review Comment:
   Hmm, there is already unsigned `test_coercion` test for `BitwiseOr`. For `BitwiseAnd` and `BitwiseXor`, they have both unsigned and signed `test_coercion` test, so I guess that you actually want to add signed `test_coercion` test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org