You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Panagiotis Garefalakis (Jira)" <ji...@apache.org> on 2020/11/08 21:41:00 UTC

[jira] [Updated] (ORC-595) Optimize Decimal64 scale calculation

     [ https://issues.apache.org/jira/browse/ORC-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Panagiotis Garefalakis updated ORC-595:
---------------------------------------
    Affects Version/s: 1.7.0

> Optimize Decimal64 scale calculation
> ------------------------------------
>
>                 Key: ORC-595
>                 URL: https://issues.apache.org/jira/browse/ORC-595
>             Project: ORC
>          Issue Type: Improvement
>          Components: encoding
>    Affects Versions: 1.7.0
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Critical
>             Fix For: 1.7.0
>
>         Attachments: DecimalBench-Clean-scale2.log, DecimalBench-ORC-595-scale2.log, DecimalBenchPerf-Clean.log, DecimalBenchPerf-ORC-595.log, Profile-ORC-595-clean.png, Profile-ORC-595-patch.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently Decimal64 is using an inner loop to apply the correct scale to each read Long value [https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java#L1294]
> A more efficient way would be to apply the scale using a single array access and by multiplying by 10 in the power of (scale - scratchScaleVector[r]).
> An extra optimization would be to keep all powers of 10 (up to 18) in a static array and reuse it across runtime instead of calculating each time.
> cc: [~rameshkumar] [~gopalv]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)