You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/19 13:34:22 UTC

[GitHub] [iceberg] miR172 opened a new pull request #3316: Refactor

miR172 opened a new pull request #3316:
URL: https://github.com/apache/iceberg/pull/3316


   Addressing #3291 
   Refactor JdbcCatalog.
   1) Added CatalogDb interface for Db operations
   2) Move all db access code into a default impl of CatalogDb
   3) Customized JdbcCatalog can use other types of db (different semantices, Cloud SQL etc) or advanced db driver (like Jooq) by implementing their own CatalogDb, which should remain in customized repo.
   4) Unify error handling in Catalog: CatalogDb throws checked Exception with error code; JdbcCatalog (and TableOperations) convert that checked Exception to Iceberg specific exception if possible. 
   
   This extends the capability of JdbcCatalog to work with various of SQL-speaking database; modulize the code for easier unit testing; and prevent SQL schema/query change to affect the entire Jdbc module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org