You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "roykoand (via GitHub)" <gi...@apache.org> on 2026/09/11 07:35:42 UTC
[PR] Fix lock_rows never acquiring a database row lock [airflow]
roykoand opened a new pull request, #72928:
URL: https://github.com/apache/airflow/pull/72928
lock_rows() built a locked query via with_row_locks() but never executed it against the database, so the SELECT ... FOR UPDATE was never sent and no row lock was actually taken. This left its only caller, set_task_group_state's bulk clear/mark-state action, without the concurrency protection it was written to rely on: a user clearing or marking a task group could race with the scheduler concurrently processing the same Dag run, with no database-level serialization between the two despite the code appearing to guard against it.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] Yes (Claude Sonnet 5)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lock_rows never acquiring a database row lock [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #72928:
URL: https://github.com/apache/airflow/pull/72928#issuecomment-6511713341
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lock_rows never acquiring a database row lock [airflow]
Posted by "roykoand (via GitHub)" <gi...@apache.org>.
roykoand commented on PR #72928:
URL: https://github.com/apache/airflow/pull/72928#issuecomment-5632203273
The failing check (`Special tests / Latest Boto test: providers`) is unrelated to this PR.
**Failure:** `test_waiter_deferrable` in `providers/amazon/tests/unit/amazon/aws/waiters/test_base_waiter.py` fails with `ModuleNotFoundError: No module named 'aiobotocore'`.
This PR only touches `airflow-core/src/airflow/utils/sqlalchemy.py` and its test — nothing related to the amazon provider or boto3/aiobotocore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lock_rows never acquiring a database row lock [airflow]
Posted by "github-actions[bot] (via GitHub) via commits" <co...@airflow.apache.org>.
github-actions[bot] closed pull request #72928: Fix lock_rows never acquiring a database row lock
URL: https://github.com/apache/airflow/pull/72928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org