You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/11 23:34:01 UTC
[GitHub] [commons-io] MartensCedric opened a new pull request #204: Changed IndexOOB to ArrayIndexOOB
MartensCedric opened a new pull request #204:
URL: https://github.com/apache/commons-io/pull/204
This is slightly more precise : https://stackoverflow.com/questions/34266174/difference-between-arrayindexoutofboundsexception-and-indexoutofboundsexception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory closed pull request #204: Changed IndexOOB to ArrayIndexOOB
Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #204:
URL: https://github.com/apache/commons-io/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory edited a comment on pull request #204: Changed IndexOOB to ArrayIndexOOB
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #204:
URL: https://github.com/apache/commons-io/pull/204#issuecomment-780218203
-1: Probably a good idea but not in this form. Most (if not all) of Commons IO uses `IndexOutOfBoundsException` for this type of failure, so if you want to make such a change, it should be done consistently _throughout_ the code, not in just one random location. Currently I see 10 locations that throw `IndexOutOfBoundsException`.
The argument against is that the JRE uses `IndexOutOfBoundsException` in methods like `java.io.InputStream.read(byte[], int, int)` and `java.io.BufferedWriter.write(char[], int, int)`, so we have to ask ourselves if we want to diverge from that pattern. IMO, probably. Let's if any one else opines.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] coveralls commented on pull request #204: Changed IndexOOB to ArrayIndexOOB
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #204:
URL: https://github.com/apache/commons-io/pull/204#issuecomment-777872451
[](https://coveralls.io/builds/37074613)
Coverage remained the same at 89.251% when pulling **dd1ef6b1b5558f02f32b4fe9727c2f9c17529a1e on MartensCedric:patch-1** into **5c3971765186c596659dd81793c2b6a01cabf6aa on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #204: Changed IndexOOB to ArrayIndexOOB
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #204:
URL: https://github.com/apache/commons-io/pull/204#issuecomment-912962589
Closing: No reply since my February 16 comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory commented on pull request #204: Changed IndexOOB to ArrayIndexOOB
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #204:
URL: https://github.com/apache/commons-io/pull/204#issuecomment-780218203
-1: Probably a sood idea but not in this form. Most (if not all) of Commons IO uses `IndexOutOfBoundsException` for this type of failure, so if you want to make such a change, it should be done consistently _throughout_ the code, not in just one random location. Currently I see 10 locations that throw `IndexOutOfBoundsException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-io] garydgregory edited a comment on pull request #204: Changed IndexOOB to ArrayIndexOOB
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #204:
URL: https://github.com/apache/commons-io/pull/204#issuecomment-780218203
-1: Probably a good idea but not in this form. Most (if not all) of Commons IO uses `IndexOutOfBoundsException` for this type of failure, so if you want to make such a change, it should be done consistently _throughout_ the code, not in just one random location. Currently I see 10 locations that throw `IndexOutOfBoundsException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org