[jira] [Commented] (FLINK-8636) Pass TaskManagerServices to TaskExecutor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360177#comment-16360177 ] 

ASF GitHub Bot commented on FLINK-8636:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5456

    [FLINK-8636] [flip6] Use TaskManagerServices to pass in services to TaskExecutor

    ## What is the purpose of the change
    
    Pass in the TaskExecutor services via the TaskManagerServices instead
    of individually.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink taskManagerServices

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5456
    
----
commit 22445a483b21e6f4a46442b11f6090a3f172c32a
Author: Till Rohrmann <tr...@...>
Date:   2018-02-11T22:18:06Z

    [FLINK-8636] [flip6] Use TaskManagerServices to pass in services to TaskExecutor
    
    Pass in the TaskExecutor services via the TaskManagerServices instead
    of individually.

----


> Pass TaskManagerServices to TaskExecutor
> ----------------------------------------
>
>                 Key: FLINK-8636
>                 URL: https://issues.apache.org/jira/browse/FLINK-8636
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to maintain the sheer number of {{TaskExecutor}} services, we should pass them to the {{TaskExecutor}} via the {{TaskManagerServices}} instead of individually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)