You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Rashko Rejmer (JIRA)" <ji...@apache.org> on 2007/07/05 21:29:05 UTC
[jira] Created: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Wrong calculation of Billing Account available balance
------------------------------------------------------
Key: OFBIZ-1128
URL: https://issues.apache.org/jira/browse/OFBIZ-1128
Project: OFBiz
Issue Type: Bug
Components: accounting
Reporter: Rashko Rejmer
Priority: Minor
Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
Next go to the page of that billing account. The available balance of the account is calculated this way:
availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
This patch should fix that problem.
Regards,
Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-1128.
------------------------------------
Resolution: Won't Fix
Thanks Rashko,
this is a good catch!
Your patch is in rev. 553754
Rashko, it seems to me that you are testing a lot the billing account processes and this is great since they have been broken for too much time and I've recently worked on a refactoring of billing account related processes.
In your opinion, are we approaching a usable status for this functionality?
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reassigned OFBIZ-1128:
----------------------------------------
Assignee: Jacopo Cappellato
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Rashko Rejmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rashko Rejmer updated OFBIZ-1128:
---------------------------------
Attachment: billingAccountAmountCalculation.patch
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Wickersheimer Jeremy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510606 ]
Wickersheimer Jeremy commented on OFBIZ-1128:
---------------------------------------------
Excuse my intrusion, i do not know much about the business but maybe it was intended to count only the approved orders ?
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato closed OFBIZ-1128.
------------------------------------
Resolution: Fixed
Changed Resolution from "Won't fix" (that was wrong) to "Fixed"
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacopo Cappellato reopened OFBIZ-1128:
--------------------------------------
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Jacopo Cappellato (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510675 ]
Jacopo Cappellato commented on OFBIZ-1128:
------------------------------------------
Jeremy,
thanks, your comment is interesting but it is not an issue here: in fact the order payment statuses considered by balance routine are selected with an IN construct.
There was an issue indeed as described by Rashko.
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1128) Wrong calculation of Billing Account
available balance
Posted by "Rashko Rejmer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510669 ]
Rashko Rejmer commented on OFBIZ-1128:
--------------------------------------
Hi Jacopo,
It is true I am testing billing accounts and order payments behavior.
I think that billing accounts are working very well now, and your re-factoring made their logic more simple and functional.
Regards,
Rashko Rejmer
> Wrong calculation of Billing Account available balance
> ------------------------------------------------------
>
> Key: OFBIZ-1128
> URL: https://issues.apache.org/jira/browse/OFBIZ-1128
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Reporter: Rashko Rejmer
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: billingAccountAmountCalculation.patch
>
>
> Try to create two sales orders that are payed with one billing account and make them with different statuses - for example the first one with status "ORDER_CREATED" and the second one with status "ORDER_APPROVED".
> Next go to the page of that billing account. The available balance of the account is calculated this way:
> availableBalance = billingAccountLimit - amount of the second order. The amount of the first orders is not considered at all.
> I thing that this is happening because of the query to the "OrderPurchasePaymentSummary" entity. This entity doesn't group the OrderPaymentPreference records that has different order statuses.
> This patch should fix that problem.
> Regards,
> Rashko Rejmer
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.