You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/08/27 15:17:40 UTC
[PR] bug: pass these only if exists [maven-javadoc-plugin]
cstamas opened a new pull request, #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313
As request carries the "effective" value (default or user overriden ones) but it does not mean they exist. And as invoker used, effect is same as user would use -s/-t CLI commands with non-existent files: mvn CLI failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-810] [REGRESSION] MJAVADOC-791 causes forked Maven execution fail if any toolchains or settings file isn't present [maven-javadoc-plugin]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2313240741
Let's wait for IT and will create JIRA issue and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313#discussion_r1733080306
##########
src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java:
##########
@@ -781,9 +781,13 @@ protected static void invokeMaven(
request.setBaseDirectory(projectFile.getParentFile());
request.setPomFile(projectFile);
request.setGlobalSettingsFile(globalSettingsFile);
- request.setUserSettingsFile(userSettingsFile);
+ if (userSettingsFile.isFile()) {
Review Comment:
more needed: UT will NPE as it tests with null value while in maven-core/embedder this value is never null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-810] [REGRESSION] MJAVADOC-791 causes forked Maven execution fail if any toolchains or settings file isn't present [maven-javadoc-plugin]
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #313: [MJAVADOC-810] [REGRESSION] MJAVADOC-791 causes forked Maven execution fail if any toolchains or settings file isn't present
URL: https://github.com/apache/maven-javadoc-plugin/pull/313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2313235235
@cstamas I modified the code to respect the method contract and not to pass non-existing values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2313237148
Lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MJAVADOC-810] [REGRESSION] MJAVADOC-791 causes forked Maven execution fail if any toolchains or settings file isn't present [maven-javadoc-plugin]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on PR #313:
URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2957403501
Resolve #1187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org