You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by bh...@apache.org on 2020/05/20 22:01:32 UTC

[beam] branch master updated: [BEAM-10037] BeamSqlExample.java fails to build (#11754)

This is an automated email from the ASF dual-hosted git repository.

bhulette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 758d821  [BEAM-10037] BeamSqlExample.java fails to build  (#11754)
758d821 is described below

commit 758d821ac64edebf24bc1bba1f7bfa34fd03a2da
Author: omarismail94 <44...@users.noreply.github.com>
AuthorDate: Wed May 20 18:01:15 2020 -0400

    [BEAM-10037] BeamSqlExample.java fails to build  (#11754)
    
    * [BEAM-10037] BeamSqlExample.java fails to build when running ./gradlew command
    
    * [BEAM-10037] Added BeamSQLExample and PojoExample to sqlPreCommit(), and fixed coder in BeamSqlExample
    
    * [BEAM-10037] Reverted first query to c1>1 as opposed to c3. I added c3 for testing and forgot to change it back :)
    
    Co-authored-by: Omar Ismail <om...@omarismail-macbookpro.roam.corp.google.com>
---
 build.gradle                                       |  2 +
 .../sdk/extensions/sql/example/BeamSqlExample.java | 56 ++++++++++++----------
 2 files changed, 33 insertions(+), 25 deletions(-)

diff --git a/build.gradle b/build.gradle
index ca4b54e..c26a020 100644
--- a/build.gradle
+++ b/build.gradle
@@ -152,6 +152,8 @@ task javaPreCommit() {
 }
 
 task sqlPreCommit() {
+  dependsOn ":sdks:java:extensions:sql:runBasicExample"
+  dependsOn ":sdks:java:extensions:sql:runPojoExample"
   dependsOn ":sdks:java:extensions:sql:build"
   dependsOn ":sdks:java:extensions:sql:buildDependents"
 }
diff --git a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java
index 8496a71..9742a33 100644
--- a/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java
+++ b/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/example/BeamSqlExample.java
@@ -45,6 +45,7 @@ import org.apache.beam.sdk.values.TupleTag;
  * Beam documentation on how to run pipelines.
  */
 class BeamSqlExample {
+
   public static void main(String[] args) {
     PipelineOptions options = PipelineOptionsFactory.fromArgs(args).create();
     Pipeline p = Pipeline.create(options);
@@ -66,19 +67,21 @@ class BeamSqlExample {
         inputTable.apply(SqlTransform.query("select c1, c2, c3 from PCOLLECTION where c1 > 1"));
 
     // print the output record of case 1;
-    outputStream.apply(
-        "log_result",
-        MapElements.via(
-            new SimpleFunction<Row, Row>() {
-              @Override
-              public Row apply(Row input) {
-                // expect output:
-                //  PCOLLECTION: [3, row, 3.0]
-                //  PCOLLECTION: [2, row, 2.0]
-                System.out.println("PCOLLECTION: " + input.getValues());
-                return input;
-              }
-            }));
+    outputStream
+        .apply(
+            "log_result",
+            MapElements.via(
+                new SimpleFunction<Row, Row>() {
+                  @Override
+                  public Row apply(Row input) {
+                    // expect output:
+                    //  PCOLLECTION: [3, row, 3.0]
+                    //  PCOLLECTION: [2, row, 2.0]
+                    System.out.println("PCOLLECTION: " + input.getValues());
+                    return input;
+                  }
+                }))
+        .setRowSchema(type);
 
     // Case 2. run the query with SqlTransform.query over result PCollection of case 1.
     PCollection<Row> outputStream2 =
@@ -86,18 +89,21 @@ class BeamSqlExample {
             .apply(SqlTransform.query("select c2, sum(c3) from CASE1_RESULT group by c2"));
 
     // print the output record of case 2;
-    outputStream2.apply(
-        "log_result",
-        MapElements.via(
-            new SimpleFunction<Row, Row>() {
-              @Override
-              public Row apply(Row input) {
-                // expect output:
-                //  CASE1_RESULT: [row, 5.0]
-                System.out.println("CASE1_RESULT: " + input.getValues());
-                return input;
-              }
-            }));
+    outputStream2
+        .apply(
+            "log_result",
+            MapElements.via(
+                new SimpleFunction<Row, Row>() {
+                  @Override
+                  public Row apply(Row input) {
+                    // expect output:
+                    //  CASE1_RESULT: [row, 5.0]
+                    System.out.println("CASE1_RESULT: " + input.getValues());
+                    return input;
+                  }
+                }))
+        .setRowSchema(
+            Schema.builder().addStringField("stringField").addDoubleField("doubleField").build());
 
     p.run().waitUntilFinish();
   }