You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/10/02 04:14:58 UTC
[kudu-CR] [common] add PartitionSchema::HasCustomHashSchemas() method
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17895
Change subject: [common] add PartitionSchema::HasCustomHashSchemas() method
......................................................................
[common] add PartitionSchema::HasCustomHashSchemas() method
Added PartitionSchema::HasCustomHashSchemas() method and corresponding
unit test. This new method will be used in a follow-up changelist to
tell between tables with table-wide and custom per-range hash schemas.
Change-Id: I73508447677884391ae26b6b20886d85960836b7
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.h
2 files changed, 79 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/17895/1
--
To view, visit http://gerrit.cloudera.org:8080/17895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73508447677884391ae26b6b20886d85960836b7
Gerrit-Change-Number: 17895
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [common] add PartitionSchema::HasCustomHashSchemas() method
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17895 )
Change subject: [common] add PartitionSchema::HasCustomHashSchemas() method
......................................................................
[common] add PartitionSchema::HasCustomHashSchemas() method
Added PartitionSchema::HasCustomHashSchemas() method and corresponding
unit test. This new method will be used in a follow-up changelist to
tell between tables with table-wide and custom per-range hash schemas.
Change-Id: I73508447677884391ae26b6b20886d85960836b7
Reviewed-on: http://gerrit.cloudera.org:8080/17895
Tested-by: Kudu Jenkins
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.h
2 files changed, 79 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I73508447677884391ae26b6b20886d85960836b7
Gerrit-Change-Number: 17895
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [common] add PartitionSchema::HasCustomHashSchemas() method
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17895 )
Change subject: [common] add PartitionSchema::HasCustomHashSchemas() method
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73508447677884391ae26b6b20886d85960836b7
Gerrit-Change-Number: 17895
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 18:00:02 +0000
Gerrit-HasComments: No
[kudu-CR] [common] add PartitionSchema::HasCustomHashSchemas() method
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17895 )
Change subject: [common] add PartitionSchema::HasCustomHashSchemas() method
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17895
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73508447677884391ae26b6b20886d85960836b7
Gerrit-Change-Number: 17895
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Oct 2021 23:18:32 +0000
Gerrit-HasComments: No