You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/10 04:19:27 UTC

[GitHub] zhijiangW commented on issue #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool

zhijiangW commented on issue #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool
URL: https://github.com/apache/flink/pull/6809#issuecomment-428432627
 
 
   Thanks for efficient reviews! @NicoK @pnowojski 
   
   I already updated the codes based on above comments except the additional missing tests. I find there only exists one test currently related with `BufferPoolOwner` whose behavior is throwing exception when calling release memory, so the normal behavior of `BufferPoolOwner` is also missing besides with different `ResultPartitionType`. 
   
   But I think it is another topic and I want to add more tests for it in a separate JIRA which I will create later. The motivation of this PR only moves the `BufferPoolOwner` into the constructor of `LocalBufferPool` and it does not effect the previous behaviors. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services