[PR] Fix NullPointerException in Firebird transaction isolation resolution [shardingsphere]

["thswlsqls (via GitHub)" <gi...@apache.org>]

thswlsqls opened a new pull request, #39136:
URL: https://github.com/apache/shardingsphere/pull/39136

   Fixes #39133.
   
   Changes proposed in this pull request:
     - Guard `FirebirdStartTransactionPacket.getIsolationLevel()` with `null !=` before reading the BOOLEAN-format `CONCURRENCY` and `CONSISTENCY` transaction parameter buffer flags, so an absent flag no longer triggers an unboxing `NullPointerException`.
     - Align these two checks with the sibling guards already used for `READ_COMMITTED`, `isAutoCommit`, and `isReadOnly`, which all test `null !=` on `tpb.getValue(...)`.
     - Rework `assertIsolationLevelSerializable` and `assertIsolationLevelNone` to build the packet through the real `parseBuffer` path instead of reflectively injecting a `CONCURRENCY -> false` entry that `parseBuffer` can never produce; the previous injection masked the NPE. Remove the now-unused reflective helper and its imports.
     - Wire format is unchanged and the fix is backward compatible.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   - [x] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix NullPointerException in Firebird transaction isolation resolution [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39136:
URL: https://github.com/apache/shardingsphere/pull/39136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix NullPointerException in Firebird transaction isolation resolution [shardingsphere]

["thswlsqls (via GitHub)" <gi...@apache.org>]

thswlsqls commented on PR #39136:
URL: https://github.com/apache/shardingsphere/pull/39136#issuecomment-5030852303

   Thanks for the review. You're right — an omitted isolation flag should resolve to Firebird's default CONCURRENCY, not `NONE`, which Jaybird rejects. Fixed: the no-isolation case now returns `TransactionIsolationLevel.REPEATABLE_READ` (keeping `CONSISTENCY` → `SERIALIZABLE`), with the regression test updated.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org