You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/10 16:21:22 UTC
[GitHub] [cordova-plugin-geolocation] breautek commented on issue #189:
Variable for Require GPS Hardware
breautek commented on issue #189: Variable for Require GPS Hardware
URL: https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-597178340
> why isn't this merged ? this or #171 @breautek
Two main reasons:
1. Because both PRs introduce preference in a `UPPERCASE_FORMAT`, which doesn't match existing format cordova uses for preferences, which in a `PascalCase` format. I'm hesitate to add inconsitencies.
2. Generally speaking, we need at least two positive votes and 0 negative votes from apache members for a PR to be accepted. So even if I agreed with this PR, I need one more member to review before I can merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org