You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/29 16:37:39 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8310:
[FLINK-12331][network] Introduce partition/gate setup to decouple task
registration with NetworkEnvironment
zhijiangW commented on a change in pull request #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8310#discussion_r279442622
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateFairnessTest.java
##########
@@ -266,13 +281,14 @@ public void testFairConsumptionRemoteChannels() throws Exception {
// Utilities
// ------------------------------------------------------------------------
- private SingleInputGate createFairnessVerifyingInputGate(int numberOfChannels) {
+ private SingleInputGate createFairnessVerifyingInputGate(int numberOfChannels, NetworkBufferPool bufferPool) {
Review comment:
Not need this field actually. In my first version for this test it was not a class field. After refactoring to class field I forgot to change this part.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services