You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by Antonio <an...@vieiro.net> on 2017/10/03 11:34:50 UTC

Grep CDDL (was Re: PR #46)


On 03/10/17 12:59, Antonio wrote:
> 
> I'll investigate the grep operation on CDDL and will post here with my 
> findings.
> 

It seems ant-rat is not able to do this.

Anyway one can quickly find CDDL files with
	grep -R CDDL --exclude-dir build

Or adding

     <target name="grep-cddl" depends="bootstrap">
         <exec osfamily="unix" executable="grep" failonerror="yes">
             <arg line="-R CDDL --exclude-dir build" />
         </exec>
     </target>

to nbbuild/build.xml and then running ant grep-cddl

This is Linux specific (and should run in OS/X as well).

Want another PR with this?

Cheers,
Antonio

Re: Grep CDDL (was Re: PR #46)

Posted by Antonio Vieiro <an...@vieiro.net>.
Aha! I now understand :-)

I’ll doublecheck that the files excluded don’t have any original license headers.

Thanks,
Antonio


> El 3 oct 2017, a las 15:36, Jan Lahoda <la...@gmail.com> escribió:
> 
> Sorry, I probably should have been more precise.
> 
> All I meant was a check that the files excluded from Rat don't have the
> original license header (as due to the excludes, Rat would no longer report
> them). I tried to check, and it seems that none of the excluded files has
> the headers, so this should be OK.
> 
> Thanks,
>     Jan
> 
> 
> On Tue, Oct 3, 2017 at 1:34 PM, Antonio <an...@vieiro.net> wrote:
> 
>> 
>> 
>> On 03/10/17 12:59, Antonio wrote:
>> 
>>> 
>>> I'll investigate the grep operation on CDDL and will post here with my
>>> findings.
>>> 
>>> 
>> It seems ant-rat is not able to do this.
>> 
>> Anyway one can quickly find CDDL files with
>>        grep -R CDDL --exclude-dir build
>> 
>> Or adding
>> 
>>    <target name="grep-cddl" depends="bootstrap">
>>        <exec osfamily="unix" executable="grep" failonerror="yes">
>>            <arg line="-R CDDL --exclude-dir build" />
>>        </exec>
>>    </target>
>> 
>> to nbbuild/build.xml and then running ant grep-cddl
>> 
>> This is Linux specific (and should run in OS/X as well).
>> 
>> Want another PR with this?
>> 
>> Cheers,
>> Antonio
>>

Re: Grep CDDL (was Re: PR #46)

Posted by Jan Lahoda <la...@gmail.com>.
Sorry, I probably should have been more precise.

All I meant was a check that the files excluded from Rat don't have the
original license header (as due to the excludes, Rat would no longer report
them). I tried to check, and it seems that none of the excluded files has
the headers, so this should be OK.

Thanks,
     Jan


On Tue, Oct 3, 2017 at 1:34 PM, Antonio <an...@vieiro.net> wrote:

>
>
> On 03/10/17 12:59, Antonio wrote:
>
>>
>> I'll investigate the grep operation on CDDL and will post here with my
>> findings.
>>
>>
> It seems ant-rat is not able to do this.
>
> Anyway one can quickly find CDDL files with
>         grep -R CDDL --exclude-dir build
>
> Or adding
>
>     <target name="grep-cddl" depends="bootstrap">
>         <exec osfamily="unix" executable="grep" failonerror="yes">
>             <arg line="-R CDDL --exclude-dir build" />
>         </exec>
>     </target>
>
> to nbbuild/build.xml and then running ant grep-cddl
>
> This is Linux specific (and should run in OS/X as well).
>
> Want another PR with this?
>
> Cheers,
> Antonio
>

Re: Grep CDDL (was Re: PR #46)

Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hey,

Am Dienstag, den 03.10.2017, 13:34 +0200 schrieb Antonio:
> 
> On 03/10/17 12:59, Antonio wrote:
> > 
> > I'll investigate the grep operation on CDDL and will post here with
> > my 
> > findings.
> > 
> 
> It seems ant-rat is not able to do this.
> 
> Anyway one can quickly find CDDL files with
> 	grep -R CDDL --exclude-dir build
> 
> Or adding
> 
>      <target name="grep-cddl" depends="bootstrap">
>          <exec osfamily="unix" executable="grep" failonerror="yes">
>              <arg line="-R CDDL --exclude-dir build" />
>          </exec>
>      </target>
> 
> to nbbuild/build.xml and then running ant grep-cddl
> 
> This is Linux specific (and should run in OS/X as well).
> 
> Want another PR with this?

I would not add greps for CDDL to the build scripts. Before adding the
excludes I suggest to cleanup the files that would be ignored and make
sure these are clean. Reintroductions via PRs need to be prevented by
the authors/committers.

Greetings

Matthias