You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "PsiACE (via GitHub)" <gi...@apache.org> on 2026/01/14 12:42:53 UTC
[PR] docs: document build and test workflows (datasketches-rust)
PsiACE opened a new pull request, #69:
URL: https://github.com/apache/datasketches-rust/pull/69
Closes #68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document build and test workflows (datasketches-rust)
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on code in PR #69:
URL: https://github.com/apache/datasketches-rust/pull/69#discussion_r2696602781
##########
CONTRIBUTING.md:
##########
@@ -32,6 +32,84 @@ cargo version
To keep code style consistent, run `cargo x lint --fix` to automatically fix any style issues before committing your changes.
+## Build and Test
+
+We recommend using `cargo x` as a single entrypoint (provided by the workspace `xtask` crate). This repo defines the `cargo x` alias in `.cargo/config.toml`, which maps to `cargo run --package x -- ...`.
+
+Build:
+
+```shell
+cargo build --workspace
+```
+
+Test:
+
+```shell
+cargo x test
+# or
+cargo test --workspace --no-default-features
+```
+
+Lint:
+
+```shell
+cargo x lint
+```
+
+## Manual workflow (without xtask)
Review Comment:
The manual workflow is hidden behind xtask, meaning most developers can safely ignore it. However, explaining how it works may be necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document build and test workflows (datasketches-rust)
Posted by "PsiACE (via GitHub)" <gi...@apache.org>.
PsiACE commented on PR #69:
URL: https://github.com/apache/datasketches-rust/pull/69#issuecomment-3749481587
cc @tisonkun @notfilippo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document build and test workflows (datasketches-rust)
Posted by "Standing-Man (via GitHub)" <gi...@apache.org>.
Standing-Man commented on code in PR #69:
URL: https://github.com/apache/datasketches-rust/pull/69#discussion_r2696562479
##########
CONTRIBUTING.md:
##########
@@ -32,6 +32,84 @@ cargo version
To keep code style consistent, run `cargo x lint --fix` to automatically fix any style issues before committing your changes.
+## Build and Test
+
+We recommend using `cargo x` as a single entrypoint (provided by the workspace `xtask` crate). This repo defines the `cargo x` alias in `.cargo/config.toml`, which maps to `cargo run --package x -- ...`.
+
+Build:
+
+```shell
+cargo build --workspace
+```
+
+Test:
+
+```shell
+cargo x test
+# or
+cargo test --workspace --no-default-features
+```
+
+Lint:
+
+```shell
+cargo x lint
+```
+
+## Manual workflow (without xtask)
Review Comment:
Hi @PsiACE and @tisonkun, Why do we need the manual workflow part? Why not use xtask uniformly for building, testing, and linting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] docs: document build and test workflows (datasketches-rust)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho merged PR #69:
URL: https://github.com/apache/datasketches-rust/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org