You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/23 12:16:27 UTC

[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request #4903: ShadingRule and AbstractOrchestrationDataSource lambda modify.

yu199195 opened a new pull request #4903:  ShadingRule and AbstractOrchestrationDataSource lambda modify.
URL: https://github.com/apache/incubator-shardingsphere/pull/4903
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #4903: ShadingRule and AbstractOrchestrationDataSource lambda modify.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4903:  ShadingRule and AbstractOrchestrationDataSource lambda modify.
URL: https://github.com/apache/incubator-shardingsphere/pull/4903#issuecomment-602564338
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=h1) Report
   > Merging [#4903](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ac11781e16d31a7da719d58d5ec491b19a0afadf&el=desc) will **decrease** coverage by `0.03%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4903      +/-   ##
   ============================================
   - Coverage     54.59%   54.56%   -0.04%     
     Complexity      434      434              
   ============================================
     Files          1138     1138              
     Lines         20452    20436      -16     
     Branches       3762     3757       -5     
   ============================================
   - Hits          11166    11150      -16     
     Misses         8579     8579              
     Partials        707      707              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `79.57% <100.00%> (-0.56%)` | `0.00 <0.00> (ø)` | |
   | [...al/datasource/AbstractOrchestrationDataSource.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL2RhdGFzb3VyY2UvQWJzdHJhY3RPcmNoZXN0cmF0aW9uRGF0YVNvdXJjZS5qYXZh) | `93.93% <100.00%> (-0.80%)` | `0.00 <0.00> (ø)` | |
   | [...chestration/internal/util/DataSourceConverter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL3V0aWwvRGF0YVNvdXJjZUNvbnZlcnRlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...hardingsphere/spring/boot/util/DataSourceUtil.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L3V0aWwvRGF0YVNvdXJjZVV0aWwuamF2YQ==) | `80.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=footer). Last update [ac11781...9af3823](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4903: ShadingRule and AbstractOrchestrationDataSource lambda modify.

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4903:  ShadingRule and AbstractOrchestrationDataSource lambda modify.
URL: https://github.com/apache/incubator-shardingsphere/pull/4903
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4903: ShadingRule and AbstractOrchestrationDataSource lambda modify.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4903:  ShadingRule and AbstractOrchestrationDataSource lambda modify.
URL: https://github.com/apache/incubator-shardingsphere/pull/4903#issuecomment-602567762
 
 
   ## Pull Request Test Coverage Report for [Build 10503](https://coveralls.io/builds/29549373)
   
   * **3** of **3**   **(100.0%)**  changed or added relevant lines in **3** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.02%**) to **58.093%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29549373/badge)](https://coveralls.io/builds/29549373) |
   | :-- | --: |
   | Change from base [Build 10493](https://coveralls.io/builds/29542363): |  -0.02% |
   | Covered Lines: | 11876 |
   | Relevant Lines: | 20443 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4903: ShadingRule and AbstractOrchestrationDataSource lambda modify.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4903:  ShadingRule and AbstractOrchestrationDataSource lambda modify.
URL: https://github.com/apache/incubator-shardingsphere/pull/4903#issuecomment-602567762
 
 
   ## Pull Request Test Coverage Report for [Build 10505](https://coveralls.io/builds/29552216)
   
   * **6** of **6**   **(100.0%)**  changed or added relevant lines in **4** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.03%**) to **58.079%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29552216/badge)](https://coveralls.io/builds/29552216) |
   | :-- | --: |
   | Change from base [Build 10493](https://coveralls.io/builds/29542363): |  -0.03% |
   | Covered Lines: | 11869 |
   | Relevant Lines: | 20436 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4903: ShadingRule and AbstractOrchestrationDataSource lambda modify.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4903:  ShadingRule and AbstractOrchestrationDataSource lambda modify.
URL: https://github.com/apache/incubator-shardingsphere/pull/4903#issuecomment-602564338
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=h1) Report
   > Merging [#4903](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/ac11781e16d31a7da719d58d5ec491b19a0afadf&el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4903      +/-   ##
   ============================================
   - Coverage     54.59%   54.57%   -0.02%     
     Complexity      434      434              
   ============================================
     Files          1138     1138              
     Lines         20452    20443       -9     
     Branches       3762     3759       -3     
   ============================================
   - Hits          11166    11157       -9     
     Misses         8579     8579              
     Partials        707      707              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `79.57% <100.00%> (-0.56%)` | `0.00 <0.00> (ø)` | |
   | [...al/datasource/AbstractOrchestrationDataSource.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL2RhdGFzb3VyY2UvQWJzdHJhY3RPcmNoZXN0cmF0aW9uRGF0YVNvdXJjZS5qYXZh) | `93.93% <100.00%> (-0.80%)` | `0.00 <0.00> (ø)` | |
   | [...hardingsphere/spring/boot/util/DataSourceUtil.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLXNwcmluZy1ib290LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NwcmluZy9ib290L3V0aWwvRGF0YVNvdXJjZVV0aWwuamF2YQ==) | `80.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=footer). Last update [ac11781...de785bf](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4903?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services