You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/05/30 18:00:48 UTC
Review Request 22085: Usability: .repo file template should be part of a
Stack definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22085/
-----------------------------------------------------------
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-5965
https://issues.apache.org/jira/browse/AMBARI-5965
Repository: ambari
Description
-------
Currently, Ambari generates HDP.repo automatically when performing an
installation. HDP.repo includes the base urls for the HDP repository.
Users often need control over this time, to set priorities, enable/disable gpg
check, etc. They might even just want this file to have the repos disabled
(because they Red Hat Satellite handling registering repos with the hosts).
We should include in each Stack a template .repo file which is used for the
.repo generation. If users need to handle customization of anything in that
template, they can do so at the Stack.
Diffs
-----
ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 32fa75b
ambari-agent/src/main/python/resource_management/libraries/resources/repository.py ad6c919
ambari-agent/src/main/python/resource_management/libraries/script/script.py 3fbb067
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py 9b200af
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 49a01cf
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py bb68560
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 852a439
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
Diff: https://reviews.apache.org/r/22085/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 22085: Usability: .repo file template should be part of a
Stack definition
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22085/#review44391
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On May 30, 2014, 5:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22085/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 5:43 p.m.)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-5965
> https://issues.apache.org/jira/browse/AMBARI-5965
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, Ambari generates HDP.repo automatically when performing an
> installation. HDP.repo includes the base urls for the HDP repository.
>
> Users often need control over this time, to set priorities, enable/disable gpg
> check, etc. They might even just want this file to have the repos disabled
> (because they Red Hat Satellite handling registering repos with the hosts).
>
> We should include in each Stack a template .repo file which is used for the
> .repo generation. If users need to handle customization of anything in that
> template, they can do so at the Stack.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 32fa75b
> ambari-agent/src/main/python/resource_management/libraries/resources/repository.py ad6c919
> ambari-agent/src/main/python/resource_management/libraries/script/repo_installer.py 082aaea
> ambari-agent/src/main/python/resource_management/libraries/script/script.py 3fbb067
> ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 529a887
> ambari-agent/src/test/python/resource_management/TestScript.py 23bbef1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py 9b200af
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 49a01cf
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py bb68560
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 852a439
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py e7b8678
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 8f6d64b
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e15ec8b
>
> Diff: https://reviews.apache.org/r/22085/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22085: Usability: .repo file template should be part of a
Stack definition
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22085/#review44393
-----------------------------------------------------------
Committed to trunk
- Dmytro Sen
On May 30, 2014, 5:43 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22085/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 5:43 p.m.)
>
>
> Review request for Ambari and Dmytro Sen.
>
>
> Bugs: AMBARI-5965
> https://issues.apache.org/jira/browse/AMBARI-5965
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Currently, Ambari generates HDP.repo automatically when performing an
> installation. HDP.repo includes the base urls for the HDP repository.
>
> Users often need control over this time, to set priorities, enable/disable gpg
> check, etc. They might even just want this file to have the repos disabled
> (because they Red Hat Satellite handling registering repos with the hosts).
>
> We should include in each Stack a template .repo file which is used for the
> .repo generation. If users need to handle customization of anything in that
> template, they can do so at the Stack.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 32fa75b
> ambari-agent/src/main/python/resource_management/libraries/resources/repository.py ad6c919
> ambari-agent/src/main/python/resource_management/libraries/script/repo_installer.py 082aaea
> ambari-agent/src/main/python/resource_management/libraries/script/script.py 3fbb067
> ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 529a887
> ambari-agent/src/test/python/resource_management/TestScript.py 23bbef1
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py 9b200af
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 49a01cf
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py bb68560
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 852a439
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py e7b8678
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json 8f6d64b
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e15ec8b
>
> Diff: https://reviews.apache.org/r/22085/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22085: Usability: .repo file template should be part of a
Stack definition
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22085/
-----------------------------------------------------------
(Updated May 30, 2014, 5:43 p.m.)
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-5965
https://issues.apache.org/jira/browse/AMBARI-5965
Repository: ambari
Description
-------
Currently, Ambari generates HDP.repo automatically when performing an
installation. HDP.repo includes the base urls for the HDP repository.
Users often need control over this time, to set priorities, enable/disable gpg
check, etc. They might even just want this file to have the repos disabled
(because they Red Hat Satellite handling registering repos with the hosts).
We should include in each Stack a template .repo file which is used for the
.repo generation. If users need to handle customization of anything in that
template, they can do so at the Stack.
Diffs (updated)
-----
ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 32fa75b
ambari-agent/src/main/python/resource_management/libraries/resources/repository.py ad6c919
ambari-agent/src/main/python/resource_management/libraries/script/repo_installer.py 082aaea
ambari-agent/src/main/python/resource_management/libraries/script/script.py 3fbb067
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 529a887
ambari-agent/src/test/python/resource_management/TestScript.py 23bbef1
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py 9b200af
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 49a01cf
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py bb68560
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 852a439
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py e7b8678
ambari-server/src/test/python/stacks/2.0.6/configs/default.json 8f6d64b
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e15ec8b
Diff: https://reviews.apache.org/r/22085/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 22085: Usability: .repo file template should be part of a
Stack definition
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22085/
-----------------------------------------------------------
(Updated May 30, 2014, 4:45 p.m.)
Review request for Ambari and Dmytro Sen.
Bugs: AMBARI-5965
https://issues.apache.org/jira/browse/AMBARI-5965
Repository: ambari
Description
-------
Currently, Ambari generates HDP.repo automatically when performing an
installation. HDP.repo includes the base urls for the HDP repository.
Users often need control over this time, to set priorities, enable/disable gpg
check, etc. They might even just want this file to have the repos disabled
(because they Red Hat Satellite handling registering repos with the hosts).
We should include in each Stack a template .repo file which is used for the
.repo generation. If users need to handle customization of anything in that
template, they can do so at the Stack.
Diffs (updated)
-----
ambari-agent/src/main/python/resource_management/libraries/providers/repository.py 32fa75b
ambari-agent/src/main/python/resource_management/libraries/resources/repository.py ad6c919
ambari-agent/src/main/python/resource_management/libraries/script/repo_installer.py 082aaea
ambari-agent/src/main/python/resource_management/libraries/script/script.py 3fbb067
ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 529a887
ambari-agent/src/test/python/resource_management/TestScript.py 23bbef1
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/hook.py 9b200af
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 49a01cf
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/hook.py bb68560
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py 852a439
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_debian.j2 PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2 PRE-CREATION
ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py e7b8678
ambari-server/src/test/python/stacks/2.0.6/configs/default.json 8f6d64b
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e15ec8b
Diff: https://reviews.apache.org/r/22085/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk