[GitHub] mistercrunch commented on a change in pull request #6687: Add `extra` column to `SavedQuery`

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6687: Add `extra` column to `SavedQuery`
URL: https://github.com/apache/incubator-superset/pull/6687#discussion_r247762997
 
 

 ##########
 File path: superset/views/sql_lab.py
 ##########
 @@ -75,6 +75,9 @@ def pre_update(self, obj):
 
 
 class SavedQueryViewApi(SavedQueryView):
+    list_columns = [
+        'label', 'sqlalchemy_uri', 'user_email', 'schema', 'description',
 
 Review comment:
   Do we need `sqlalchemy_uri` and `user_email` in the list view, how about the database name and user name in instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org