You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/09 18:00:13 UTC
Review Request 28854: Fixed build error caused by overloading socket
call on CentOS 5
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28854/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Ian Downes.
Repository: mesos-git
Description
-------
Fixed build error caused by overloading socket call on CentOS 5
Diffs
-----
3rdparty/libprocess/include/process/socket.hpp 916576f7b901ab57a03395cef403964a050835b1
Diff: https://reviews.apache.org/r/28854/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28854: Fixed build error caused by overloading
socket call on CentOS 5
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28854/#review64422
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Dec. 9, 2014, 5 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28854/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 5 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build error caused by overloading socket call on CentOS 5
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 916576f7b901ab57a03395cef403964a050835b1
>
> Diff: https://reviews.apache.org/r/28854/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28854: Fixed build error caused by overloading
socket call on CentOS 5
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28854/#review64393
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28854]
All tests passed.
- Mesos ReviewBot
On Dec. 9, 2014, 5 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28854/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 5 p.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build error caused by overloading socket call on CentOS 5
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 916576f7b901ab57a03395cef403964a050835b1
>
> Diff: https://reviews.apache.org/r/28854/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28854: Fixed build error caused by overloading
socket call on CentOS 5
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28854/#review64400
-----------------------------------------------------------
Ship it!
Confirmed this patch built successfully under the previously failing CI environment (Centos5 with dev-toolset2 providing gcc-4.8.2).
- Ian Downes
On Dec. 9, 2014, 9 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28854/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2014, 9 a.m.)
>
>
> Review request for mesos, Ben Mahler and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fixed build error caused by overloading socket call on CentOS 5
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/socket.hpp 916576f7b901ab57a03395cef403964a050835b1
>
> Diff: https://reviews.apache.org/r/28854/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>