CODEOWNERS vs CODEWATCHERS

[Owen Nichols <on...@vmware.com>]

The Geode community has certainly become closer now that CODEOWNERS automatically adds a lot of people to the reviewer list for new PRs, but you may still feel like you’re missing out on PRs outside your area of expertise.

If you are a committer and there are additional code areas you’d like to be automatically added as an optional reviewer (as opposed to a binding codeowner), you can now do that through CODEWATCHERS.  Same file format, same process (submit a PR to make any changes).

Re: CODEOWNERS vs CODEWATCHERS

[Owen Nichols <on...@vmware.com>]

Apache+GitHub only allows committers to be added as reviewers, so unfortunately only Geode committers can be added to either CODEOWNERS or CODEWATCHERS at this time.

Contributors interested in following changes to any file, directory, or subtree may wish to try GitHub's ".atom" suffixing to generate a live feed [1], for example to watch geode-wan add this url to your favorite feed reader [2].

If you can think of another way to notify non-committers I'd be willing to consider it.  For example, maybe CODEWATCHERS could tag them in a comment if they haven't been previously tagged or something like that, let me know if that would be helpful.

[1] https://docs.github.com/en/rest/reference/activity#feeds
[2] https://github.com/apache/geode/commits/develop/geode-wan.atom

On 3/18/21, 3:57 PM, "Alberto Bustamante Reyes" <al...@est.tech> wrote:

    Hi,

    Is it possible to add contributors to the CODEWATCHERS file? Or is it strictly necessary to be a committer?

    BR/

    Alberto B.
    ________________________________
    De: Owen Nichols <on...@vmware.com>
    Enviado: viernes, 12 de marzo de 2021 23:38
    Para: dev@geode.apache.org <de...@geode.apache.org>
    Asunto: CODEOWNERS vs CODEWATCHERS

    The Geode community has certainly become closer now that CODEOWNERS automatically adds a lot of people to the reviewer list for new PRs, but you may still feel like you’re missing out on PRs outside your area of expertise.

    If you are a committer and there are additional code areas you’d like to be automatically added as an optional reviewer (as opposed to a binding codeowner), you can now do that through CODEWATCHERS.  Same file format, same process (submit a PR to make any changes).

RE: CODEOWNERS vs CODEWATCHERS

[Alberto Bustamante Reyes <al...@est.tech>]

Hi,

Is it possible to add contributors to the CODEWATCHERS file? Or is it strictly necessary to be a committer?

BR/

Alberto B.
________________________________
De: Owen Nichols <on...@vmware.com>
Enviado: viernes, 12 de marzo de 2021 23:38
Para: dev@geode.apache.org <de...@geode.apache.org>
Asunto: CODEOWNERS vs CODEWATCHERS

The Geode community has certainly become closer now that CODEOWNERS automatically adds a lot of people to the reviewer list for new PRs, but you may still feel like you’re missing out on PRs outside your area of expertise.

If you are a committer and there are additional code areas you’d like to be automatically added as an optional reviewer (as opposed to a binding codeowner), you can now do that through CODEWATCHERS.  Same file format, same process (submit a PR to make any changes).