You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/03 10:27:27 UTC
[GitHub] [airflow] inytar opened a new pull request #7611: [AIRFLOW-6014]
reschedule deleted pending tasks
inytar opened a new pull request #7611: [AIRFLOW-6014] reschedule deleted pending tasks
URL: https://github.com/apache/airflow/pull/7611
This code checks if a k8s process has been deleted and was in the
pending state, if so it will reschedule the task.
This is an alternative implementation of https://github.com/apache/airflow/pull/6606, which we have been using internally. I don't have any preference on which PR to use, wanted to show what we have been running in production for some time.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- There seem to be no tests for `KubernetesJobWatchers`, and it requires a lot of k8s api knowledge it seems, I would be happy with some help on moving forward with this.
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] inytar commented on issue #7611: [AIRFLOW-6014]
reschedule deleted pending tasks
Posted by GitBox <gi...@apache.org>.
inytar commented on issue #7611: [AIRFLOW-6014] reschedule deleted pending tasks
URL: https://github.com/apache/airflow/pull/7611#issuecomment-600075269
A alternative version in #6606 has already been merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] inytar closed pull request #7611: [AIRFLOW-6014]
reschedule deleted pending tasks
Posted by GitBox <gi...@apache.org>.
inytar closed pull request #7611: [AIRFLOW-6014] reschedule deleted pending tasks
URL: https://github.com/apache/airflow/pull/7611
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services