You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Julie Zhuo (JIRA)" <be...@incubator.apache.org> on 2005/02/28 20:41:49 UTC
[jira] Created: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
----------------------------------------------------------------------------------------
Key: BEEHIVE-378
URL: http://issues.apache.org/jira/browse/BEEHIVE-378
Project: Beehive
Type: Bug
Components: NetUI
Versions: V1Beta
Reporter: Julie Zhuo
Assigned to: Rich Feit
Attachments: JIRA378Repro.ZIP
When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
@Jpf.Action(loginRequired = false,
forwards={
@Jpf.Forward(name="index", path="index.jsp")
})
protected Forward begin()
{
return new Forward("index");
}
Now, it is overidden in the child like this.
@Jpf.Action(
forwards={
@Jpf.Forward(name="index", path="index.jsp")
}
)
protected Forward begin()
{
return new Forward("index");
}
The child generates the struts config like this,
<action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
<forward name="index" path="/index.jsp"/>
</action>
So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
This is found in SVN 155338.
Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-378?page=history ]
Rich Feit resolved BEEHIVE-378:
-------------------------------
Assign To: Julie Zhuo (was: Rich Feit)
Resolution: Fixed
Fixed with revision 155757. Nice catch.
> Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
> ----------------------------------------------------------------------------------------
>
> Key: BEEHIVE-378
> URL: http://issues.apache.org/jira/browse/BEEHIVE-378
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Reporter: Julie Zhuo
> Assignee: Julie Zhuo
> Fix For: V1Beta
> Attachments: JIRA378Repro.ZIP
>
> When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
> @Jpf.Action(loginRequired = false,
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> })
> protected Forward begin()
> {
> return new Forward("index");
> }
> Now, it is overidden in the child like this.
> @Jpf.Action(
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> }
> )
> protected Forward begin()
> {
> return new Forward("index");
> }
> The child generates the struts config like this,
> <action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
> <forward name="index" path="/index.jsp"/>
> </action>
> So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
> This is found in SVN 155338.
> Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Reopened: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-378?page=history ]
Rich Feit reopened BEEHIVE-378:
-------------------------------
Assign To: Rich Feit (was: Julie Zhuo)
I see what you meant now -- you weren't really trying to override the annotations on one begin method with another one (those were just examples). So this a real issue. Sorry about that...
> Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
> ----------------------------------------------------------------------------------------
>
> Key: BEEHIVE-378
> URL: http://issues.apache.org/jira/browse/BEEHIVE-378
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Reporter: Julie Zhuo
> Assignee: Rich Feit
> Fix For: V1Beta
> Attachments: JIRA378Repro.ZIP
>
> When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
> @Jpf.Action(loginRequired = false,
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> })
> protected Forward begin()
> {
> return new Forward("index");
> }
> Now, it is overidden in the child like this.
> @Jpf.Action(
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> }
> )
> protected Forward begin()
> {
> return new Forward("index");
> }
> The child generates the struts config like this,
> <action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
> <forward name="index" path="/index.jsp"/>
> </action>
> So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
> This is found in SVN 155338.
> Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Resolved: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-378?page=history ]
Rich Feit resolved BEEHIVE-378:
-------------------------------
Assign To: Julie Zhuo (was: Rich Feit)
Resolution: Invalid
Fix Version: V1Beta
This is actually by design -- we don't merge annotations on action methods. That might be a good feature enhancement request, though. :)
> Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
> ----------------------------------------------------------------------------------------
>
> Key: BEEHIVE-378
> URL: http://issues.apache.org/jira/browse/BEEHIVE-378
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Reporter: Julie Zhuo
> Assignee: Julie Zhuo
> Fix For: V1Beta
> Attachments: JIRA378Repro.ZIP
>
> When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
> @Jpf.Action(loginRequired = false,
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> })
> protected Forward begin()
> {
> return new Forward("index");
> }
> Now, it is overidden in the child like this.
> @Jpf.Action(
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> }
> )
> protected Forward begin()
> {
> return new Forward("index");
> }
> The child generates the struts config like this,
> <action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
> <forward name="index" path="/index.jsp"/>
> </action>
> So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
> This is found in SVN 155338.
> Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Posted by "Julie Zhuo (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-378?page=comments#action_59879 ]
Julie Zhuo commented on BEEHIVE-378:
------------------------------------
Relating issue JIRA227.
> Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
> ----------------------------------------------------------------------------------------
>
> Key: BEEHIVE-378
> URL: http://issues.apache.org/jira/browse/BEEHIVE-378
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Reporter: Julie Zhuo
> Assignee: Rich Feit
> Attachments: JIRA378Repro.ZIP
>
> When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
> @Jpf.Action(loginRequired = false,
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> })
> protected Forward begin()
> {
> return new Forward("index");
> }
> Now, it is overidden in the child like this.
> @Jpf.Action(
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> }
> )
> protected Forward begin()
> {
> return new Forward("index");
> }
> The child generates the struts config like this,
> <action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
> <forward name="index" path="/index.jsp"/>
> </action>
> So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
> This is found in SVN 155338.
> Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Posted by "Julie Zhuo (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-378?page=history ]
Julie Zhuo closed BEEHIVE-378:
------------------------------
Verified fixed as of rev 156432
> Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
> ----------------------------------------------------------------------------------------
>
> Key: BEEHIVE-378
> URL: http://issues.apache.org/jira/browse/BEEHIVE-378
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Reporter: Julie Zhuo
> Assignee: Julie Zhuo
> Fix For: V1Beta
> Attachments: JIRA378Repro.ZIP
>
> When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
> @Jpf.Action(loginRequired = false,
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> })
> protected Forward begin()
> {
> return new Forward("index");
> }
> Now, it is overidden in the child like this.
> @Jpf.Action(
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> }
> )
> protected Forward begin()
> {
> return new Forward("index");
> }
> The child generates the struts config like this,
> <action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
> <forward name="index" path="/index.jsp"/>
> </action>
> So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
> This is found in SVN 155338.
> Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (BEEHIVE-378) Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
Posted by "Julie Zhuo (JIRA)" <be...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/BEEHIVE-378?page=history ]
Julie Zhuo updated BEEHIVE-378:
-------------------------------
Attachment: JIRA378Repro.ZIP
> Overriding loginRequired to false when when rolesAllowed is set in the parent Controller
> ----------------------------------------------------------------------------------------
>
> Key: BEEHIVE-378
> URL: http://issues.apache.org/jira/browse/BEEHIVE-378
> Project: Beehive
> Type: Bug
> Components: NetUI
> Versions: V1Beta
> Reporter: Julie Zhuo
> Assignee: Rich Feit
> Attachments: JIRA378Repro.ZIP
>
> When loginRequired is set to true in the parent pageflow controller and it is overridden by loginRequired=false in the child pageflow controller, the begin action is set as the following in the parent.
> @Jpf.Action(loginRequired = false,
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> })
> protected Forward begin()
> {
> return new Forward("index");
> }
> Now, it is overidden in the child like this.
> @Jpf.Action(
> forwards={
> @Jpf.Forward(name="index", path="index.jsp")
> }
> )
> protected Forward begin()
> {
> return new Forward("index");
> }
> The child generates the struts config like this,
> <action path="/begin" type="org.apache.beehive.netui.pageflow.internal.FlowControllerAction" parameter="testInheritance.override.actionForward.ActionForwardController" scope="request" roles="role1,role2" validate="false">
> <forward name="index" path="/index.jsp"/>
> </action>
> So, when try to enter in the pageflow by begin.do, it still requires a current logged in user.
> This is found in SVN 155338.
> Repro apps will be attached shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira