You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 14:03:50 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #11000:
[FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
tillrohrmann opened a new pull request #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000
## What is the purpose of the change
Upgrade jackson-databind dependency to 2.10.1
cc @wangyang0918
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581963715
Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581962614
I think you are mistakingly counting relocated Jackson dependencies. If you run `jar tf flink-dist_2.11-1.11-SNAPSHOT.jar| grep ^com/fasterxml/jackson | wc -l` then you will get `0`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581946562
Well, actually I would like to leave it like this because at the moment we don't have a unrelocated jackson dependency in `flink-dist`. I think it should be a follow-up issue to unify the differently relocated Jackson dependencies and to have a single version in Flink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581957088
@tillrohrmann I have checked the `flink-dist_2.11-1.11-SNAPSHOT.jar`. It seems that we have already bundle the unrelocated jackson.
```
wangyang-pc:build-target danrtsey.wy$ unzip -l lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep 'com/fasterxml/jackson' | grep -v 'shaded' | wc -l
908
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11000:
[FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581449042
<!--
Meta data
Hash:d49b5333b6177e24ce710f7d51ade550648741f1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147213561 TriggerType:PUSH TriggerID:d49b5333b6177e24ce710f7d51ade550648741f1
Hash:d49b5333b6177e24ce710f7d51ade550648741f1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4787 TriggerType:PUSH TriggerID:d49b5333b6177e24ce710f7d51ade550648741f1
-->
## CI report:
* d49b5333b6177e24ce710f7d51ade550648741f1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147213561) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4787)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581942410
Good point @wangyang0918. I'll remove the relocations then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 edited a comment on issue #11000:
[FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581957088
@tillrohrmann I have checked the `flink-dist_2.11-1.11-SNAPSHOT.jar`. It seems that we have already bundled the unrelocated jackson.
```
wangyang-pc:build-target danrtsey.wy$ unzip -l lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep 'com/fasterxml/jackson' | grep -v 'shaded' | wc -l
908
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581449042
<!--
Meta data
Hash:d49b5333b6177e24ce710f7d51ade550648741f1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d49b5333b6177e24ce710f7d51ade550648741f1
-->
## CI report:
* d49b5333b6177e24ce710f7d51ade550648741f1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11000:
[FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581449042
<!--
Meta data
Hash:d49b5333b6177e24ce710f7d51ade550648741f1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147213561 TriggerType:PUSH TriggerID:d49b5333b6177e24ce710f7d51ade550648741f1
Hash:d49b5333b6177e24ce710f7d51ade550648741f1 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4787 TriggerType:PUSH TriggerID:d49b5333b6177e24ce710f7d51ade550648741f1
-->
## CI report:
* d49b5333b6177e24ce710f7d51ade550648741f1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147213561) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4787)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581429781
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit d49b5333b6177e24ce710f7d51ade550648741f1 (Mon Feb 03 14:06:25 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-582499821
Hmm this is strange. Which version of maven did you use for building Flink @wangyang0918? I think it should be `<= 3.2.5` otherwise shading might not properly work. I checked also the RC1 and I couldn't find unrelocated Jackson dependencies in it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-582748464
@tillrohrmann You are right. The maven version `>3.2.5` could not shade the `jackson` properly. Let's unify the different relocated `jackson` dependencies in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11000:
[FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#discussion_r374171406
##########
File path: flink-kubernetes/pom.xml
##########
@@ -35,6 +35,17 @@ under the License.
<kubernetes.client.version>4.5.2</kubernetes.client.version>
</properties>
+ <!-- Set dependency version for transitive dependencies -->
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>com.squareup.okhttp3</groupId>
+ <artifactId>okhttp</artifactId>
Review comment:
Seems unrelated (good idea though).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-582207186
@tillrohrmann I think the two commands have no differences.
I build the master branch and still could find the unrelocated `jackson` classes. Do i miss something?
```
$ jar tf lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep ^com/fasterxml/jackson | wc -l
908
```
```
$ jar tf lib/flink-dist_2.11-1.11-SNAPSHOT.jar | grep ^com/fasterxml/jackson | head -n 10
com/fasterxml/jackson/
com/fasterxml/jackson/databind/
com/fasterxml/jackson/databind/AbstractTypeResolver.class
com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty$Type.class
com/fasterxml/jackson/databind/AnnotationIntrospector$ReferenceProperty.class
com/fasterxml/jackson/databind/AnnotationIntrospector.class
com/fasterxml/jackson/databind/BeanDescription.class
com/fasterxml/jackson/databind/BeanProperty$Bogus.class
com/fasterxml/jackson/databind/BeanProperty$Std.class
com/fasterxml/jackson/databind/BeanProperty.class
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11000: [FLINK-15864][k8s]
Upgrade jackson-databind dependency to 2.10.1
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11000: [FLINK-15864][k8s] Upgrade jackson-databind dependency to 2.10.1
URL: https://github.com/apache/flink/pull/11000#issuecomment-581711129
@tillrohrmann Thanks for creating this PR.
The current version(4.5.2) of kubernetes-client has fixed problem about different version conflict of dependency `com.fasterxml.jackson`. So of cause, we could remove the `exclude` part and using transitive dependencies.
Then if we remove the explicit dependencies and exclusions, i think we do not need to shade the `com.fasterxml.jackson` related packages anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services