[GitHub] [druid] capistrant edited a comment on pull request #10676: Allow client to configure batch ingestion task to wait to complete until segments are confirmed to be available by other

[GitBox <gi...@apache.org>]

capistrant edited a comment on pull request #10676:
URL: https://github.com/apache/druid/pull/10676#issuecomment-811464591


   @suneet-s I took a stab at a CompactionTuningConfig that basically fronts the ParallelIndexTuningConfig that it had been using. This allows us to enforce a check that a non-null or 0 value for `awaitSegmentAvailabilityTimeoutMillis` and causes the job to fail if set differently in the provided tuningConfig. Since this is all the TuningConfig does, I suggest we leave it undocumented and add documentation stating `awaitSegmentAvailabilityTimeoutMillis` is not supported for compaction tasks at this time. 
   
   I still have to test this new code locally, but I wanted to get it up for review and CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org