You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2023/01/16 11:03:26 UTC
[GitHub] [hive] kasakrisz commented on a diff in pull request #3935: HIVE-26717: Query based Rebalance compaction on insert-only tables
kasakrisz commented on code in PR #3935:
URL: https://github.com/apache/hive/pull/3935#discussion_r1071107854
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##########
@@ -315,10 +315,14 @@ protected Boolean findNextCompactionAndExecute(boolean collectGenericStats, bool
return false;
}
- if (!ci.type.equals(CompactionType.REBALANCE) && ci.numberOfBuckets > 0) {
- if (LOG.isWarnEnabled()) {
- LOG.warn("Only the REBALANCE compaction accepts the number of buckets clause (CLUSTERED INTO {N} BUCKETS). " +
- "Since the compaction request is {}, it will be ignored.", ci.type);
+ boolean insertOnly = AcidUtils.isInsertOnlyTable(table.getParameters());
+ if (LOG.isWarnEnabled() && ci.type.equals(CompactionType.REBALANCE) && insertOnly) {
Review Comment:
Can `ci` and `ci.type` be null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org