You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tweise <gi...@git.apache.org> on 2018/06/17 19:04:00 UTC
[GitHub] flink pull request #6177: Backport of Kinesis connector changes from 1.5 to ...
GitHub user tweise opened a pull request:
https://github.com/apache/flink/pull/6177
Backport of Kinesis connector changes from 1.5 to release-1.4
Backport of Kinesis connector changes from 1.5 release to 1.4.
R: @tzulitai @tillrohrmann
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tweise/flink release-1.4-kinesis
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6177.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6177
----
commit a231c3c2f6e2aa1148d002a517ee67226ea78af4
Author: Thomas Weise <th...@...>
Date: 2018-01-31T01:44:44Z
[FLINK-8516] [kinesis] Allow for custom hash function for shard to subtask mapping in Kinesis consumer
This closes #5393.
commit 17d6b49583492f0f3b7fe9db5ffcd508fa324864
Author: Thomas Weise <th...@...>
Date: 2018-02-14T00:33:59Z
[FLINK-8648] [kinesis] Allow for customization of emitRecordAndUpdateState in Kinesis connector.
This closes #5480.
commit 6ef1e9e0ae124e7bb0e375867fb78ada9e6a0e74
Author: Kailash HD <kd...@...>
Date: 2018-03-08T18:32:23Z
[FLINK-8888] [Kinesis Connectors] Update the AWS SDK for flink kinesis connector
This closes #5663
commit 2ff1279bf63555b238670e66f3e0785b0214e00a
Author: Kailash HD <kd...@...>
Date: 2018-03-14T16:20:12Z
[FLINK-8945] [kinesis] Allow customization of KinesisProxy
This closes #5698
commit 2ba9306a0db24f6de49cf7b99991d7e5b4b28eae
Author: Thomas Weise <th...@...>
Date: 2018-04-03T03:49:50Z
[FLINK-9124] [kinesis] Allow customization of KinesisProxy.getRecords read timeout and retry.
This closes #5803.
commit a734e53f59cdad56c84f99d85aa2b05a2e395b78
Author: Moser Thomas W <mo...@...>
Date: 2018-04-27T18:27:03Z
[FLINK-9266] [kinesis] Updates Kinesis connector to use newer version of kcl to limit describe streams calls
This closes #5932.
----
---
[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6177
@tweise I've manually merged this, but forgot to add the "This closes #xxxx" message.
Could you close this PR manually? Thanks!
---
[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6177
I'm not sure that we want to backport the shard-mapping hash function. IMO, that is a new feature and shouldn't go into a bugfix release.
What do you think @tweise?
---
[GitHub] flink pull request #6177: Backport of Kinesis connector changes from 1.5 to ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/6177
---
[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/6177
@tweise ok, I don't really have a strong opinion on not including the other changes.
Changes LGTM then, will merge this.
---
[GitHub] flink issue #6177: Backport of Kinesis connector changes from 1.5 to release...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on the issue:
https://github.com/apache/flink/pull/6177
@tzulitai the commits in this PR (except the most recent version change) are from our 1.4.x fork and what we use in production. As discussed on the ML not even the Kinesis version number is strictly a patch compatible change and I don't see an issue including the other changes, too.
---