You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/05/18 22:28:04 UTC

[GitHub] [beam] ajothomas commented on a change in pull request #14835: BEAM-12358: Add Nullable annotation to key field in TimerKey

ajothomas commented on a change in pull request #14835:
URL: https://github.com/apache/beam/pull/14835#discussion_r634793063



##########
File path: runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaTimerInternalsFactory.java
##########
@@ -572,6 +572,7 @@ private void init() {
 
   @AutoValue
   abstract static class TimerKey<K> {
+    @javax.annotation.Nullable

Review comment:
       There is another conflicting import `import org.checkerframework.checker.nullness.qual.Nullable;` due to which I had to use the fully qualified class name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org