You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/06/17 13:57:31 UTC

[GitHub] [incubator-druid] leventov commented on a change in pull request #7889: Use only google annotations GuardedBy instead JavaX

leventov commented on a change in pull request #7889: Use only google annotations GuardedBy instead JavaX
URL: https://github.com/apache/incubator-druid/pull/7889#discussion_r294310727
 
 

 ##########
 File path: codestyle/druid-forbidden-apis.txt
 ##########
 @@ -42,4 +42,7 @@ com.ibm.icu.text.SimpleDateFormat#<init>(java.lang.String)
 
 @defaultMessage For performance reasons, use the utf8Base64 / encodeBase64 / encodeBase64String / decodeBase64 / decodeBase64String methods in StringUtils
 org.apache.commons.codec.binary.Base64
-com.google.common.io.BaseEncoding.base64
\ No newline at end of file
+com.google.common.io.BaseEncoding.base64
+
+@defaultMessage Use com.google.errorprone.annotations.concurrent.GuardedBy
 
 Review comment:
   It could be just a single line: `javax.annotations.concurrent.GuardedBy @ Use com.google.errorprone.annotations.concurrent.GuardedBy`. Please keep in mind when adding forbidden API rules in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org