You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/09/21 02:31:38 UTC

[GitHub] [carbondata] QiangCai commented on a change in pull request #3391: [CARBONDATA-3521] optimize read property file code

QiangCai commented on a change in pull request #3391: [CARBONDATA-3521] optimize read property file code
URL: https://github.com/apache/carbondata/pull/3391#discussion_r326843649
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
 ##########
 @@ -81,7 +81,7 @@ private CarbonCommonConstants() {
    * default carbon properties file path
    */
   public static final String CARBON_PROPERTIES_FILE_PATH_DEFAULT =
-      "../../../conf/carbon.properties";
 
 Review comment:
   please keep the old default value. if we change it, it will impact the user to upgrade the old version to a new version.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services