You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/21 05:58:06 UTC
[GitHub] [netbeans] KacerCZ opened a new pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
KacerCZ opened a new pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550
https://issues.apache.org/jira/browse/NETBEANS-5048
Allows to cancel Find Usages action in PHP editor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528395488
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
Review comment:
Volatile is OK here, IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tmysik commented on pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#issuecomment-732263196
@KacerCZ
You are welcome. Thanks for your work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528317028
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
Review comment:
Added comment why `cancelled` is reset.
For `cancelled` I used same type as in OccurencesFinderImpl in PHP Editor:
https://github.com/apache/netbeans/blob/514e170f43416aec1a25c1c443837bf1ef9043f0/php/php.editor/src/org/netbeans/modules/php/editor/csl/OccurrencesFinderImpl.java#L62
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528290942
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
Review comment:
@tmysik Instead, should use `AtomicBoolean.compareAndSet()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528289529
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
+ cancelled = false;
Review comment:
Ah, I see. You are right. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528269270
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
+ cancelled = false;
Review comment:
Maybe, need not this. `cancelled` is used only here at the moment, but I think we should keep the cancelled state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 merged pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
junichi11 merged pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#issuecomment-731942841
@junichi11 @tmysik Thanks for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528292452
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
Review comment:
We should leave a comment about why we change it to `false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] KacerCZ commented on a change in pull request #2550: [NETBEANS-5048] PHP - cancel Find Usages action
Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2550:
URL: https://github.com/apache/netbeans/pull/2550#discussion_r528288269
##########
File path: php/php.refactoring/src/org/netbeans/modules/refactoring/php/findusages/PhpWhereUsedQueryPlugin.java
##########
@@ -63,6 +64,10 @@ public Problem prepare(final RefactoringElementsBag elementsBag) {
if (fileObject == null) {
continue;
}
+ if (cancelled) {
+ cancelled = false;
Review comment:
If state is left, then it is impossible to repeat action by clicking green arrows in Usages window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists