You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/19 03:49:24 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request, #16670: [fix][broker] Fix consumer does not abide by the max unacks limitation

codelipenghui opened a new pull request, #16670:
URL: https://github.com/apache/pulsar/pull/16670

   Fixes #16667
   
   ### Motivation
   
   Fix the consumer does not abide by the max unacks limitation.
   The root cause is the dispatcher only cares about the flow permits while
   dispatching messages but doesn't care if the dispatched messages
   will exceed the max unacks limitation.
   
   The issue is easy to reproduce if max_unacks < receiver_queue_size
   
   ### Modifications
   
   Calculate the dispatch messages count for a consumer with
   `max_unacks - unacks`
   
   ### Verifying this change
   
   A new test added to verify the consumer will not receive
   messages more than max unacks limitation
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #16670: [fix][broker] Fix consumer does not abide by the max unacks limitation for Shared subscription

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16670:
URL: https://github.com/apache/pulsar/pull/16670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui commented on pull request #16670: [fix][broker] Fix consumer does not abide by the max unacks limitation

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on PR #16670:
URL: https://github.com/apache/pulsar/pull/16670#issuecomment-1188632405

   > Is a similar fix needed for other dispatcher implementation classes such as PersistentDispacherSingleActiveConsumer?
   
   @lhotari Oh, good point. I will take a look at the Key_Shared subscription, It's might different from Shared subscription. For the single active consumer subscription, we don't have unacks limitations for now, so we don't need a fix for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] RobertIndie commented on pull request #16670: [fix][broker] Fix consumer does not abide by the max unacks limitation

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on PR #16670:
URL: https://github.com/apache/pulsar/pull/16670#issuecomment-1188572198

   I think this PR can also fix https://github.com/apache/pulsar/issues/16663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari commented on pull request #16670: [fix][broker] Fix consumer does not abide by the max unacks limitation

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #16670:
URL: https://github.com/apache/pulsar/pull/16670#issuecomment-1188600246

   Is a similar fix needed for other dispatcher implementation classes such as PersistentDispacherSingleActiveConsumer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org