[GitHub] [cassandra] Maxwell-Guo commented on a diff in pull request #2047: Add compaction type output result for nodetool compactionhistory for CASSANDRA-18061

[GitBox <gi...@apache.org>]

Maxwell-Guo commented on code in PR #2047:
URL: https://github.com/apache/cassandra/pull/2047#discussion_r1066831242


##########
src/java/org/apache/cassandra/db/compaction/CompactionHistoryTabularData.java:
##########
@@ -74,10 +74,14 @@ public static TabularData from(UntypedResultSet resultSet) throws OpenDataExcept
             long bytesIn = row.getLong(ITEM_NAMES[4]);
             long bytesOut = row.getLong(ITEM_NAMES[5]);
             Map<Integer, Long> rowMerged = row.getMap(ITEM_NAMES[6], Int32Type.instance, LongType.instance);
-
+            String compactionType = OperationType.UNKNOWN.type;
+            if (row.has(ITEM_NAMES[7]))

Review Comment:
   Thanks @jacek-lewandowski 
   Yes, if a migration for this system table  is added , This method is no longer need. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org