You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "xvrl (via GitHub)" <gi...@apache.org> on 2023/08/17 19:42:50 UTC

Re: [PR] fix KafkaInputFormat with nested columns (druid)

xvrl commented on PR #13406:
URL: https://github.com/apache/druid/pull/13406#issuecomment-1682862319

   it looks like this patch introduced a significant performance regression. We had to revert this fix in our deployment, since this was causing massive GC pressure.
   
   With this change StreamAppenderatorDriver.add now accounts for 75% of allocations in SeekableStreamIndexTaskRunner.runInternal, but after reverting this patch, it came back down to only ~4% of allocations
   
    
   <img width="1384" alt="Screenshot 2023-08-17 at 3 41 17 PM" src="https://github.com/apache/druid/assets/815147/ae160dc5-d5a8-4b35-aca2-f10fa753e27e">
   <img width="1408" alt="Screenshot 2023-08-17 at 3 41 35 PM" src="https://github.com/apache/druid/assets/815147/bd1e7145-e2d7-475c-9fbb-d457e0a48bd3">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org