You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ar...@apache.org on 2019/01/31 19:07:32 UTC

[impala] 06/07: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

This is an automated email from the ASF dual-hosted git repository.

arodoni pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit ee491bb67da2d62b2b801d6ff0de40fc286411b9
Author: Lars Volker <lv...@cloudera.com>
AuthorDate: Mon Jan 28 10:56:55 2019 -0800

    IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC
    
    Running against S3 and erasure coded HDFS causes slight changes in the
    observed ExchangeScanRatio and breaks such tests. This change limits
    TestObservability::test_global_exchange_counters to HDFS local
    minicluster runs without EC.
    
    Change-Id: I6cf58113e092d43f5444120040aa49f90cdb91fb
    Reviewed-on: http://gerrit.cloudera.org:8080/12288
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_observability.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/query_test/test_observability.py b/tests/query_test/test_observability.py
index 3aa2514..963ace1 100644
--- a/tests/query_test/test_observability.py
+++ b/tests/query_test/test_observability.py
@@ -19,7 +19,8 @@ from collections import defaultdict
 from datetime import datetime
 from tests.common.impala_cluster import ImpalaCluster
 from tests.common.impala_test_suite import ImpalaTestSuite
-from tests.common.skip import SkipIfS3, SkipIfABFS, SkipIfADLS, SkipIfIsilon, SkipIfLocal
+from tests.common.skip import (SkipIfS3, SkipIfABFS, SkipIfADLS, SkipIfIsilon,
+                               SkipIfLocal, SkipIfNotHdfsMinicluster)
 from tests.util.filesystem_utils import IS_EC
 from time import sleep, time
 import logging
@@ -392,6 +393,7 @@ class TestObservability(ImpalaTestSuite):
                          "InnerNodeSelectivityRatio"]
     assert all(counter in profile for counter in expected_counters)
 
+  @SkipIfNotHdfsMinicluster.tuned_for_minicluster
   def test_global_exchange_counters(self):
     """Test that global exchange counters are set correctly."""
     query = """select count(*) from tpch_parquet.orders o inner join tpch_parquet.lineitem