You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "ebarboni (via GitHub)" <gi...@apache.org> on 2026/03/18 15:52:38 UTC
[PR] unit test bootstrap no securitymanager [netbeans]
ebarboni opened a new pull request, #9284:
URL: https://github.com/apache/netbeans/pull/9284
Hi,
unit test were not working using jdk21 as baseline for bootstrap. changing to release on javac target.
So this is a rewrite of the test using ant buildRule,
Most test pass without changing existing assets,
nbm and jnlp use genkey from ant but needs now algo set. I use DSA not sure it's ok.
fixdependencies use (editing later)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#issuecomment-4119088547
merging maybe can do another round of cleanup for jnlp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2954491743
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/FixTestDependenciesProject2.xml:
##########
@@ -217,14 +217,6 @@
<specification-version>6.5</specification-version>
</run-dependency>
</dependency>
- <dependency>
- <code-name-base>org.openide.options</code-name-base>
- <build-prerequisite/>
- <compile-dependency/>
- <run-dependency>
- <specification-version>6.2</specification-version>
- </run-dependency>
- </dependency>
<dependency>
Review Comment:
openide.options is removed so it should be pruned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#issuecomment-4111146265
updated project file and workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#issuecomment-4083914385
> > unit test were not working using jdk21 as baseline for bootstrap
>
> this indicates that CI isn't running those tests? Should something be added? (tests which don't run don't test anything ;))
Would be nice.
A test is KO right now with checklicense where I put System.print
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2966879182
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/InsertModuleAllTargetsTest.java:
##########
@@ -102,14 +102,14 @@ public void testInstallAllTargetWithClusters() {
insert.setProject(p);
insert.execute();
-
+
Object obj = p.getTargets().get("all-java.source.queries");
assertNotNull("Target found", obj);
Target t = (Target)obj;
Set<String> s = depsToNames(t.getDependencies());
- assertEquals("Five dependencies: " + s, 5, s.size());
- assertEquals(new HashSet<>(Arrays.asList("init", "all-openide.dialogs", "all-openide.util", "all-openide.util.lookup", "all-api.annotations.common")), s);
+ assertEquals("Five dependencies: " + s, 2, s.size());
Review Comment:
```suggestion
assertEquals("Two dependencies: " + s, 2, s.size());
```
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/PrintIconTest.java:
##########
Review Comment:
Is the verbosity level changed intentionally here? I saw in other tests that you explicitly setup with verbose logging, this is not the case here. This seems to be the case in other files too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#issuecomment-4089099162
@mbien the default build-nozip is in fact minimal. What would be the good place in workflow to have such test running?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2954482902
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/MakeJNLPTest.java:
##########
@@ -1111,13 +1163,16 @@ private File generateKeystore(String alias, String password) throws Exception {
"keystore='" + where + "' \n" +
"storepass='" + password + "' \n" +
"dname='CN=A NetBeans Friend, OU=NetBeans, O=netbeans.org, C=US' \n" +
+ "keyalg='DSA' \n" +
Review Comment:
mandatory change to have ant task executed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#issuecomment-4083736616
> unit test were not working using jdk21 as baseline for bootstrap
this indicates that CI isn't running those tests? Should something be added? (tests which don't run don't test anything ;))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2959052163
##########
nbbuild/antsrc/org/netbeans/nbbuild/CheckLicense.java:
##########
@@ -102,11 +102,9 @@ public Convert createConvert() {
while ((line = br.readLine ()) != null) {
if (line.indexOf (fragment) != -1) {
// Found it.
- if (fail != null && "whenpresent".equals(fail.getValue())) {
- if (failMsg != null) {
- log(failMsg, Project.MSG_ERR);
- }
+ if (fail != null && "whenpresent".equals(fail.getValue())) {
failMsg = "License found in " + f;
+ log(failMsg, Project.MSG_ERR);
}
Review Comment:
construct failMsg anyway, and log it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2975487767
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/InsertModuleAllTargetsTest.java:
##########
@@ -102,14 +102,14 @@ public void testInstallAllTargetWithClusters() {
insert.setProject(p);
insert.execute();
-
+
Object obj = p.getTargets().get("all-java.source.queries");
assertNotNull("Target found", obj);
Target t = (Target)obj;
Set<String> s = depsToNames(t.getDependencies());
- assertEquals("Five dependencies: " + s, 5, s.size());
- assertEquals(new HashSet<>(Arrays.asList("init", "all-openide.dialogs", "all-openide.util", "all-openide.util.lookup", "all-api.annotations.common")), s);
+ assertEquals("Five dependencies: " + s, 2, s.size());
Review Comment:
should be updated thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2954475236
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/InsertModuleAllTargetsTest.java:
##########
@@ -102,14 +102,14 @@ public void testInstallAllTargetWithClusters() {
insert.setProject(p);
insert.execute();
-
+
Object obj = p.getTargets().get("all-java.source.queries");
assertNotNull("Target found", obj);
Target t = (Target)obj;
Set<String> s = depsToNames(t.getDependencies());
- assertEquals("Five dependencies: " + s, 5, s.size());
- assertEquals(new HashSet<>(Arrays.asList("init", "all-openide.dialogs", "all-openide.util", "all-openide.util.lookup", "all-api.annotations.common")), s);
Review Comment:
here dependencies count are not 5 but 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni merged PR #9284:
URL: https://github.com/apache/netbeans/pull/9284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2975484721
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/PrintIconTest.java:
##########
Review Comment:
removed all the MSG_VERBOSE level, test are passing without
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] unit test bootstrap no securitymanager [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on code in PR #9284:
URL: https://github.com/apache/netbeans/pull/9284#discussion_r2954486197
##########
nbbuild/test/unit/src/org/netbeans/nbbuild/MakeNBMTest.java:
##########
@@ -191,13 +207,15 @@ private File generateKeystore(String alias, String password) throws Exception {
"keystore='" + where + "' \n" +
"storepass='" + password + "' \n" +
"dname='CN=A NetBeans Friend, OU=NetBeans, O=netbeans.org, C=US' \n" +
+ "keyalg='DSA' \n" +
"/>\n" +
Review Comment:
same keyalgo DSA changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists