You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/11 13:05:31 UTC

[GitHub] [cordova-docs] slothstronaut opened a new issue #1074: Android Adaptive icons conflict with plugins

slothstronaut opened a new issue #1074: Android Adaptive icons conflict with plugins
URL: https://github.com/apache/cordova-docs/issues/1074
 
 
   # Bug Report
   
   ## Problem
   
   colors.xml gets overwritten by plugins, making it appear that the documentation is incorrect
   
   ### What is expected to happen?
   
   colors.xml should write the content from your config.xml, but popular plugins overwrite this
   
   ### What does actually happen?
   
   cordova-plugin-firebasex: Updated colors.xml with accent color
   
   
   ## Information
   <!-- Include all relevant information that might help understand and reproduce the problem -->
   
   The this plugin `cordova-plugin-firebasex` overwrites the colors.xml file, which overwrites what is in the documentation. I'm not saying the functionality of the plugin is correct, but when you use it and try to implement based on the documentation it fails.
   
   Either the documentation should mention this caveat that other plugins may overwrite the colors.xml, or to specify a different xml file name since any name can be used, for example I used brand.xml
   
   ### Command or Code
   <!-- What command or code is needed to reproduce the problem? -->
   
   https://cordova.apache.org/docs/en/latest/config_ref/images.html#adaptive-icon-with-colors
   
   
   ### Environment, Platform, Device
   <!-- In what environment, on what platform or on which device are you experiencing the issue? -->
   
   Pixel 3 latest Android
   
   
   
   ### Version information
   <!-- 
   What are relevant versions you are using?
   For example:
   Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins 
   Other Frameworks: Ionic Framework and CLI version
   Operating System, Android Studio, Xcode etc.
   -->
   
   Building using cordova cli
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org