You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2016/12/14 04:52:13 UTC

Review Request 54732: Reused same json helper for `SlaveInfo`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54732/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.


Bugs: MESOS-6177
    https://issues.apache.org/jira/browse/MESOS-6177


Repository: mesos


Description
-------

Reused same json helper for `SlaveInfo`.


Diffs
-----

  src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac 

Diff: https://reviews.apache.org/r/54732/diff/


Testing
-------


Thanks,

Zhitao Li


Re: Review Request 54732: Reused same json helper for `SlaveInfo`.

Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54732/#review160202
-----------------------------------------------------------


Ship it!




I would update the summary to be more descriptive when committing.

- Anand Mazumdar


On Dec. 14, 2016, 4:52 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54732/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 4:52 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Xiaojian Huang, and Kunal Thakar.
> 
> 
> Bugs: MESOS-6177
>     https://issues.apache.org/jira/browse/MESOS-6177
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reused same json helper for `SlaveInfo`.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp d52806dcf8e4d64ebb98e191a01408c0fcae17ac 
> 
> Diff: https://reviews.apache.org/r/54732/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>