You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by qingwen220 <gi...@git.apache.org> on 2017/05/26 11:15:24 UTC

[GitHub] eagle pull request #939: EAGLE-1029: fix bug in generateGroupbyMonitorMetada...

GitHub user qingwen220 opened a pull request:

    https://github.com/apache/eagle/pull/939

    EAGLE-1029: fix bug in generateGroupbyMonitorMetadata

    https://issues.apache.org/jira/browse/EAGLE-1029

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/qingwen220/eagle EAGLE-1029

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/eagle/pull/939.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #939
    
----
commit 1596192b901ec141a538b66b6aaa1520455ef9a4
Author: Zhao, Qingwen <qi...@apache.org>
Date:   2017-05-26T11:12:17Z

    fix bug in generateSpoutMonitorMetadata

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle issue #939: EAGLE-1029: fix bug in generateGroupbyMonitorMetadata

Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:

    https://github.com/apache/eagle/pull/939
  
    This bug can be produced as follows
    
    1. create policies with stream1 to use up all the working slot of alert engine topology1
    2. setup another alert engine topology topology2
    3. create a policy with stream1 and trigger the scheduler to schedule
    4. check schedule result by GET rest/metadata/schedulestates, and compare groupSpecs & alertSpecs



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle issue #939: EAGLE-1029: fix bug in generateGroupbyMonitorMetadata

Posted by RalphSu <gi...@git.apache.org>.
Github user RalphSu commented on the issue:

    https://github.com/apache/eagle/pull/939
  
    Make sense.
    
    @qingwen220  can you please add a unit test case that reproduce this issue and make sure we fix it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle issue #939: EAGLE-1029: fix bug in generateGroupbyMonitorMetadata

Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:

    https://github.com/apache/eagle/pull/939
  
    @RalphSu  I have added a unit test. This test verifies the correctness of assigning of a policy to a new alert engine topology. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] eagle pull request #939: EAGLE-1029: fix bug in generateGroupbyMonitorMetada...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/eagle/pull/939


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---