You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/12 10:08:44 UTC
[GitHub] [airflow] potiuk opened a new pull request #8260: Make autocomplete
work better for zsh
potiuk opened a new pull request #8260: Make autocomplete work better for zsh
URL: https://github.com/apache/airflow/pull/8260
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #8260:
Make autocomplete work better for zsh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #8260: Make autocomplete work better for zsh
URL: https://github.com/apache/airflow/pull/8260#discussion_r407215382
##########
File path: breeze-complete
##########
@@ -229,12 +229,14 @@ function _comp_breeze {
fi
done
+
Review comment:
Adding new line by accident?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #8260: Make autocomplete work
better for zsh
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #8260: Make autocomplete work better for zsh
URL: https://github.com/apache/airflow/pull/8260
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #8260:
Make autocomplete work better for zsh
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #8260: Make autocomplete work better for zsh
URL: https://github.com/apache/airflow/pull/8260#discussion_r407215382
##########
File path: breeze-complete
##########
@@ -229,12 +229,14 @@ function _comp_breeze {
fi
done
+
Review comment:
Adding new line for accident?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #8260: Make
autocomplete work better for zsh
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #8260: Make autocomplete work better for zsh
URL: https://github.com/apache/airflow/pull/8260#discussion_r407225550
##########
File path: breeze-complete
##########
@@ -229,12 +229,14 @@ function _comp_breeze {
fi
done
+
Review comment:
Yep. Will remove!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #8260: Make autocomplete work
better for zsh
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #8260: Make autocomplete work better for zsh
URL: https://github.com/apache/airflow/pull/8260#issuecomment-612592094
I switched to Mojave on my Mac (work on both - Linux and MacOS now and finally I fixed the auto-complete scripts for breeze to fully support zsh. Zsh autocomplete now includes all the values (for python/backend etc. ) also autocomplete now works also if it is invoked in the middle of line - it takes the current position of the cursor to complete the right value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services