[Impala-ASF-CR] IMPALA-5474: Adding a trivial subquery turns error into warning

["Yongjun Zhang (Code Review)" <ge...@cloudera.org>]

Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 )

Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning
......................................................................


Patch Set 4:

(1 comment)

> Please file a bug for the flaky test - we need to investigate that
 > and fix it (it seems like it could be a product bug).

Agree, we can file a jira after the jira is committed, since the failed test is from testing uncommitted code.

http://gerrit.cloudera.org:8080/#/c/12022/4/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/12022/4/shell/impala_client.py@543
PS4, Line 543:     """Returns ERROR message for the last_query_handle. Caller knows that the query has
> This comment is misleading now, which is worse than no comment - this retur
Hi Tim, thanks for your review and comment. Sorry for my late reply. This method does get error or ERROR when there is, because "True" is passed to the "warn" parameter of get_warn_or_error_log. Maybe we can change the method name from get_error_log to get_error_log_if_there_is? If so, we can change the other places accordingly. Or we can modify the comment to indicate the same thing. e.g., "Returns ERROR message for the last_query_handle when applicable. ...". I prefer the latter. What do you think? thanks.



-- 
To view, visit http://gerrit.cloudera.org:8080/12022
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibedb11dd3d50bcdb21d508f7d21691925491946e
Gerrit-Change-Number: 12022
Gerrit-PatchSet: 4
Gerrit-Owner: Yongjun Zhang <yj...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Paul Rogers <pr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Yongjun Zhang <yj...@apache.org>
Gerrit-Comment-Date: Thu, 03 Jan 2019 19:55:00 +0000
Gerrit-HasComments: Yes