You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "yongwww (via GitHub)" <gi...@apache.org> on 2024/01/19 15:26:24 UTC
[PR] [CI] Update image tag to 20240119-070113-614a7a9e3 [tvm]
yongwww opened a new pull request, #16435:
URL: https://github.com/apache/tvm/pull/16435
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Update image tag to 20240126-070121-8ade9c30e [tvm]
Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on PR #16435:
URL: https://github.com/apache/tvm/pull/16435#issuecomment-1913186052
updated to the newer image (tag:20240126-070121-8ade9c30e), it was built on Jan 26. CI is green now.
Actually the current CI doesn’t really use the s3 bucket tvm-sccache-prod for sccache. Instead, the local sccahe cache is used. I have a [testing pr ](https://github.com/apache/tvm/pull/16480) to hardcode an invalid bucket and CI still passed. The sccache 0.3.3 doesn’t verify the aws credential during the —start-server, whereas the newer sccache 0.7.x does. In this PR, I changed it to use local cache if no aws credentials is available.
I conducted a benchmark comparing sccache with and without an S3 bucket on an AWS g5.4xlarge instance. The results showed that the build time without the S3 bucket (using a local cache, with an average build time of 219.48 seconds) is faster compared to using an S3 bucket (232.01 seconds average build time). Given these findings, I recommend not enabling the S3 bucket for sccache at this time.
Regarding AWS credentials, they are currently not passed to the worker container. One method is to pass AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY through the container as shown [here](https://github.com/apache/tvm/blob/main/ci/jenkins/generated/cpu_jenkinsfile.groovy#L115). However, this approach raises security concerns. We should explore alternatives like using IAM roles, task IAMs, or similar solutions for future needs, especially if we decide to enable S3 for sccache. Useful references include discussions on the best practices for passing AWS credentials to Docker containers ([Stack Overflow](https://stackoverflow.com/questions/36354423/what-is-the-best-way-to-pass-aws-credentials-to-a-docker-container)) and information about IAM roles for Amazon EC2 ([AWS EC2 User Guide](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html)) and task IAM roles ([AWS ECS Developer Guide](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-iam-roles.h
tml)).
cc: @tqchen @vinx13 @ajtulloch @naut-brian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Update image tag to 20240119-070113-614a7a9e3 [tvm]
Posted by "yongwww (via GitHub)" <gi...@apache.org>.
yongwww commented on PR #16435:
URL: https://github.com/apache/tvm/pull/16435#issuecomment-1906627439
The CI failed during `sccache --start-server` with s3 bucket, it was introduced by the sccache upgrade before #16366. Seems we can set env. variables `SCCACHE_BUCKET`, `SCCACHE_REGION`, and `AWS_PROFILE`(or `AWS_ACCESS_KEY_ID` plus `AWS_SECRET_ACCESS_KEY` instead of `AWS_PROFILE`+.aws/credentials) as mentioned in [sccache s3](https://github.com/mozilla/sccache/blob/main/docs/S3.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Update image tag to 20240126-070121-8ade9c30e [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen merged PR #16435:
URL: https://github.com/apache/tvm/pull/16435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CI] Update image tag to 20240119-070113-614a7a9e3 [tvm]
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #16435:
URL: https://github.com/apache/tvm/pull/16435#issuecomment-1900639787
cc @Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org