You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/22 16:06:04 UTC

[jira] [Commented] (BEAM-1672) Accumulable MetricsContainers.

    [ https://issues.apache.org/jira/browse/BEAM-1672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980004#comment-15980004 ] 

ASF GitHub Bot commented on BEAM-1672:
--------------------------------------

GitHub user aviemzur opened a pull request:

    https://github.com/apache/beam/pull/2649

    [BEAM-1672] Accumulable MetricsContainers.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aviemzur/beam accumulable-metricscontainer

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2649.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2649
    
----
commit 9f81af4b1a71af97672956e75298cff115c63fad
Author: Aviem Zur <av...@gmail.com>
Date:   2017-04-22T14:45:35Z

    [BEAM-1672] Make MetricsContainers accumulable.

commit 1a208e2dd7128a25cf62ee75fae4078b2af665f9
Author: Aviem Zur <av...@gmail.com>
Date:   2017-04-22T16:00:11Z

    [BEAM-1672] AccumulatedMetricsResults

commit f3f9b588eb473705506dc4bbc2020e3628e2e843
Author: Aviem Zur <av...@gmail.com>
Date:   2017-04-22T16:00:51Z

    [BEAM-1672] Use Accumulable MetricsContainers in Spark runner.

commit f41466b23ba475e141fde6d3db8c5c2fc14470c9
Author: Aviem Zur <av...@gmail.com>
Date:   2017-04-22T16:01:38Z

    [BEAM-1672] Use Accumulable MetricsContainers in Flink runner.

----


> Accumulable MetricsContainers.
> ------------------------------
>
>                 Key: BEAM-1672
>                 URL: https://issues.apache.org/jira/browse/BEAM-1672
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Aviem Zur
>            Assignee: Aviem Zur
>
> Make {{MetricsContainer}} accumulable. This can reduce duplication between runners and make implementing metrics easier.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)