You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/09/12 19:35:08 UTC
Review Request 71478: Windows: Moved definition out of inline
function call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71478/
-----------------------------------------------------------
Review request for mesos, Greg Mann and Till Toenshoff.
Repository: mesos
Description
-------
MSVC does not deal with #ifdefs from inside function calls.
So here, the `#if defined(...)` was taken literally and is
considered a syntax error by MSVC.
Diffs
-----
3rdparty/libprocess/src/openssl.cpp 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6
Diff: https://reviews.apache.org/r/71478/diff/1/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 71478: Windows: Moved definition out of inline
function call.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71478/#review217850
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Sept. 12, 2019, 7:35 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71478/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2019, 7:35 p.m.)
>
>
> Review request for mesos, Greg Mann and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MSVC does not deal with #ifdefs from inside function calls.
> So here, the `#if defined(...)` was taken literally and is
> considered a syntax error by MSVC.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6
>
>
> Diff: https://reviews.apache.org/r/71478/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71478: Windows: Moved definition out of inline
function call.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71478/#review217711
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71478]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 12, 2019, 7:35 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71478/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2019, 7:35 p.m.)
>
>
> Review request for mesos, Greg Mann and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MSVC does not deal with #ifdefs from inside function calls.
> So here, the `#if defined(...)` was taken literally and is
> considered a syntax error by MSVC.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6
>
>
> Diff: https://reviews.apache.org/r/71478/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71478: Windows: Moved definition out of inline
function call.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71478/#review217838
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Sept. 12, 2019, 7:35 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71478/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2019, 7:35 p.m.)
>
>
> Review request for mesos, Greg Mann and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> MSVC does not deal with #ifdefs from inside function calls.
> So here, the `#if defined(...)` was taken literally and is
> considered a syntax error by MSVC.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6
>
>
> Diff: https://reviews.apache.org/r/71478/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>