You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2023/05/02 05:48:15 UTC
[GitHub] [solr] dsmiley opened a new pull request, #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
dsmiley opened a new pull request, #1615:
URL: https://github.com/apache/solr/pull/1615
No longer configSet / per-core.
Existing configuration (e.g. in solrconfig.xml or via config edit API) is ignored with a deprecation warning.
Even though this is a backwards incompatible change, I think it's fine in a minor release because:
* it's easy to change
* the user gets a warning
* existing configs or config-edit won't fail (but will no-op admittedly)
* improves security
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #1615:
URL: https://github.com/apache/solr/pull/1615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531496598
> If/once Solr has a solr.env=prod|dev|test then we'd enable this setting in dev mode
@dsmiley , there's already "-Dsolr.environment=prod" in Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531509376
> Why modify solr.in.sh at all? I'd rather not; to be honest, I'd rather that file not exist at all (by default).
All lines in solr.in.sh are commented, so it is not needed by default. But the reason I'd prefer all sysprops to have their own ENV equivalent is for ease of configuration in e.g. Docker / k8s as a simple env.var instead of having to do `SOLR_OPTS` concatenation.
> @dsmiley , there's already "-Dsolr.environment=prod" in Solr.
Yes, I put it in there, and all it does now is change color in Admin UI between envs :) We could certainly re-use it to set defaults for other things. But do we want remote streaming to be enabled by default in dev/test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a diff in pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #1615:
URL: https://github.com/apache/solr/pull/1615#discussion_r1187914114
##########
solr/solr-ref-guide/modules/configuration-guide/pages/requestdispatcher.adoc:
##########
@@ -107,45 +81,11 @@ This `HttpServletRequest` is not used by any Solr component, but may be useful w
[source,xml]
----
-<requestParsers enableRemoteStreaming="false"
- enableStreamBody="false"
- multipartUploadLimitInKB="2048"
+<requestParsers multipartUploadLimitInKB="2048"
formdataUploadLimitInKB="2048"
addHttpRequestToContext="false" />
----
-The below command is an example of how to enable RemoteStreaming and BodyStreaming through the xref:config-api.adoc#commands-for-common-properties[Config API]:
Review Comment:
I prefer to not show any example on how to set any of these requestParsers details dynamically, thus I did not swap out the examples for the other still-valid configuration attributes. IMO none of these should be in solrconfig.xml in the first place -- they are obscure things that I don't think someone would want to set on any one config (collection); instead I think all of them should be global. Making stuff configurable has some maintenance cost and are arcane details to many people. This is just my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531518831
I propose in this issue not looking at solr.environment -- leave that for https://issues.apache.org/jira/browse/SOLR-15875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531955505
I'm going to commit solrconfig.xml fixes (removing now noop params and xml comments about them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531093512
Did a quick browse, looks good. I agree that this change is acceptable in a minor release, for the reasons given.
@chatman, I think it makes sense to keep the core-level settings and APIs as no-ops in 9.x, declare them as deprecated in 9x and remove in main branch only.
For all the test-solrconfig.xml files I think we can do a global search/replace `<requestParsers.*?enableRemoteStreaming=".*?"` with `<requestParsers` and the same with stream body, as these are no-op anyway now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531013540
There are lots of XML files that need to be fixed.
ishan@x1extreme ~/code/chatman-solr (branch_9_2) $ grep enableRemoteStr -rn *|grep xml|cut -d ":" -f 1|sort|uniq
solr/core/src/test-files/solr/collection1/conf/solrconfig-analytics-query.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-collapseqparser.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-components-name.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-delaying-component.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-doctransformers.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-elevate.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-follower1.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-follower.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-hash.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-leader1-keepOneBackup.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-leader1.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-leader2.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-leader3.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-leader-throttled.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-leader.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-minhash.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-nocache.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig_perf.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-plugcollector.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-repeater.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-replication-legacy.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig-sql.xml
solr/core/src/test-files/solr/collection1/conf/solrconfig.xml
solr/modules/extraction/src/test-files/extraction/solr/collection1/conf/solrconfig.xml
solr/modules/langid/src/test-files/langid/solr/collection1/conf/solrconfig-languageidentifier.xml
solr/server/solr/configsets/_default/conf/solrconfig.xml
solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
solr/solrj/src/test-files/solrj/solr/collection1/conf/solrconfig-follower1.xml
solr/solrj/src/test-files/solrj/solr/collection1/conf/solrconfig-sql.xml
solr/solrj/src/test-files/solrj/solr/collection1/conf/solrconfig.xml
solr/solrj/src/test-files/solrj/solr/configsets/ml/conf/solrconfig.xml
solr/solrj/src/test-files/solrj/solr/configsets/shared/conf/solrconfig.xml
solr/solrj/src/test-files/solrj/solr/configsets/streaming/conf/solrconfig.xml
solr/solrj/src/test-files/solrj/solr/multicore/core0/conf/solrconfig.xml
solr/solrj/src/test-files/solrj/solr/multicore/core1/conf/solrconfig.xml
solr/solrj-streaming/src/test-files/solrj/solr/configsets/ml/conf/solrconfig.xml
solr/solrj-streaming/src/test-files/solrj/solr/configsets/streaming/conf/solrconfig.xml
solr/solr-ref-guide/modules/indexing-guide/pages/content-streams.adoc
solr/test-framework/src/test-files/solr/collection1/conf/solrconfig.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a diff in pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on code in PR #1615:
URL: https://github.com/apache/solr/pull/1615#discussion_r1187965820
##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -74,9 +74,14 @@ Please refer to the https://solr.apache.org/downloads.html[Solr Downloads] site
* Solr now provides an xref:deployment-guide:shard-management.adoc#installshard[INSTALLSHARD] API to allow users who have built (per-shard) indices offline to import them into SolrCloud shards.
== Solr 9.3
-=== Improvements to Solr CLI
+=== Solr CLI
* the bin/solr -i and bin/solr -info removed in favour of bin/solr status command.
+=== Security
+* Use of `stream.file` and `stream.url` and `stream.body` params are no longer enabled via configuration in solrconfig.xml, nor dynamic equivalents with the config API.
Review Comment:
```suggestion
* Use of `stream.file`, `stream.url` and `stream.body` params are no longer enabled via configuration in solrconfig.xml, nor dynamic equivalents with the config API.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1532792875
Only RefGuide & Changes left to do here I believe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531936665
> Why modify solr.in.sh at all? I'd rather not; to be honest, I'd rather that file not exist at all (by default).
I'll push a change that only adds parsing of `SOLR_ENABLE_REMOTE_STREAMING` and `SOLR_ENABLE_STREAM_BODY` to the scripts, but nothing in `solr.in.xx`. That way we don't advertise this feature, while still allowing Solr to pick it up from the environment, and we can document both sys.prop and env.var in refGuide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531552903
Good catch, David. I think the remote streaming "functionality" should be scrapped. DumpRequestHandler should either be scrapped or, at least, shouldn't be allowed to work with remote streaming, and the https://solr.apache.org/guide/8_11/content-streams.html page should be re-written to remove all references to such features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1532997550
Yes. Thanks for your help, BTW. I'll be busy today but I offer this:
Proposed CHANGES.txt
* SOLR-14853: Security: Converted enableRemoteStreaming and enableStreamBody solrconfig options into system properties and env vars. Attempts to set them the old way will no-op and log a warning. (me, Jan, Ishan)
upgrade notes:
In order to improve security, use of stream.file and stream.url and stream.body is no longer enabled via configuration in solrconfig.xml, nor dynamic equivalents with the config API. Instead, set an env var: ___ or ___ or system property equivalents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531095476
We should also give these two new sysProps their own line and env.var in `solr.in.sh`? And unfortunately we'll also need some code in bin/solr[.cmd] for parsing it. I can contribute commits for this if you wish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531016537
> Existing configuration (e.g. in solrconfig.xml or via config edit API) is ignored with a deprecation warning.
I think they should be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "chatman (via GitHub)" <gi...@apache.org>.
chatman commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531520334
> But do we want remote streaming to be enabled by default in dev/test?
Not in my opinion. Rather, I think we should remove remote streaming from Solr. If something shouldn't be used in production, it shouldn't exist in Solr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "janhoy (via GitHub)" <gi...@apache.org>.
janhoy commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531574760
> Nor do I know why CONFIG_READ_PERM in particular was chosen.
You and I discussed this in the original PR to secure all request handlers: https://github.com/apache/solr/pull/372/files/ae46e8d101026c3439fb23a07d1603c884048765#r737730716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531543727
BTW I want to call attention to https://github.com/apache/solr/blob/6d5529a39fd995c207425da7f39e32721955b616/solr/core/src/java/org/apache/solr/handler/DumpRequestHandler.java#L129
which feels weird to me. I don't think I love varying the permission of a handler based on wether remote streaming is enabled or not. Nor do I know why CONFIG_READ_PERM in particular was chosen. I suppose this is here because it's super easy to have Solr fetch whatever URL for you on your behalf... but if you enabled remote streaming then, shrug, it all seems moot honestly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1615: SOLR-14853 enableRemoteStreaming and enableStreamBody are now sys props
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #1615:
URL: https://github.com/apache/solr/pull/1615#issuecomment-1531488428
Sure; will remove from the configs in Solr -- easy enough.
Why modify solr.in.sh at all? I'd rather not; to be honest, I'd rather that file not exist at all (by default).
If/once Solr has a solr.env=prod|dev|test then we'd enable this setting in dev mode, and then feel no need later to give it such first class treatment to deserve it's very own env (which I assume is what motivated you to suggest an entry in solr.in.sh?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org